https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1316 DRP 2-D Pipeline <p><tt>fiberids.py</tt> in <tt>python/pfs/utils/</tt> in <tt>pfs_uitls</tt> imports <tt>eups</tt> at the top section, but it is only used to look up the <tt>PFS_UTILS</tt> parameter using <tt>eups.productDir('PFS_UTILS')</tt>. As the constructor of <tt>FiberIds</tt> allows to be called with a path to the <tt>fiberid</tt> data directory, it would be nice if the import line is moved right above the line using <tt>eups</tt> to minimize the dependency to <tt>eups</tt> for Python environments not using it.</p> <p>Specifically, I'd like to move the import line to here:</p> <p><a href="https://github.com/Subaru-PFS/pfs_utils/blob/b922f60fa44dec1a96dfb5739f2c2737486c04ec/python/pfs/utils/fiberids.py#L57" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/pfs_utils/blob/b922f60fa44dec1a96dfb5739f2c2737486c04ec/python/pfs/utils/fiberids.py#L57</a></p> PIPE2D-1316

Move the location to import eups in fiberids.py of pfs_utils

Task Normal Done Done Unassigned monodera Fri, 13 Oct 2023 21:12:57 +0000 Thu, 2 Nov 2023 23:17:13 +0000 Mon, 16 Oct 2023 20:53:11 +0000 pfs_utils 0 1 <p>done by merging the tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1316" title="Move the location to import eups in fiberids.py of pfs_utils" class="issue-link" data-issue-key="PIPE2D-1316"><del>PIPE2D-1316</del></a> branch to the master branch.</p> <p>I've added a hotfix as tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1316" title="Move the location to import eups in fiberids.py of pfs_utils" class="issue-link" data-issue-key="PIPE2D-1316"><del>PIPE2D-1316</del></a>-hotfix to make makePfsDesign() compatible with providing the fiberIds data path.</p> <p> </p> Development Rank 0|zzszyv: