https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1289 DRP 2-D Pipeline <p>We need to be able to simply specify what elements of a detectorMap are to be fit.</p> PIPE2D-1289

Refactor fitting of detectorMaps to specify what should be fit

Story Normal Done Done price price EngRun Tue, 29 Aug 2023 00:25:08 +0000 Sat, 30 Sep 2023 00:37:58 +0000 Sat, 30 Sep 2023 00:37:58 +0000 0 2 <p>detectorMap fitting occurs in two contexts: fitDetectorMap (called by reduceArc) and adjustDetectorMap (called by reduceExposure, etc).<br/> fitDetectorMap fits separately a distortion field (PolynomialDistortion or DoubleDistortion, depending on whether the detector is monolithic or not) and a set of slit offsets in x and y. The distortion field is fit by solving a linear least-squares matrix problem, and the current user control consists solely of selecting the polynomial order (which is identical in x and y). The slit offsets are fit by iteratively measuring the mean residual after removing the distortion field, and the current user control consists solely of selecting whether the slit offsets will be fit or not.<br/> adjustDetectorMap fits a distortion field (RotScaleDistortion or DoubleRotScaleDistortion, depending on whether the detector is monolithic or not). The distortion field is fit by solving a linear least-squares matrix problem, and there is no user control beyond turning this task on or off.</p> <p>In order to satisfy the requirements introduced by this ticket, I propose to:</p> <ul> <li>add an array of booleans to the linear least-squares fitting (PolynomialDistortion, DoubleDistortion, RotScaleDistortion, DoubleRotScaleDistortion) that specifies if a parameter should not be fit (and therefore default to zero).</li> <li>add a configuration parameter that allows the user to directly set these booleans.</li> <li>add configuration parameters that allow the user to specify which fibers should have x or y slit offsets measured.</li> </ul> <p>We agreed at our weekly meeting that we would be able to provide values in addition to turning parameters on/off (i.e., don't default the value to zero if not being fit).</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> asked for a more detailed description of the detectorMap fitting process:</p> <p>The MultipleDistortionsDetectorMap consists of the following layers:</p> <ul> <li>The "base" model is a SplinedDetectorMap, which comes from the optical model.</li> <li>Slit offsets are applied (a spatial and spectral offset per fiber) to the optical model.</li> <li>A series of distortion fields are applied on top of these, which may be of different kinds. We currently have defined:<br/> + PolynomialDistortion: a 2D normalised polynomial (ordinary polynomial normalised to the range -1,+1)<br/> + DoubleDistortion: one PolynomialDistortion for each CCD<br/> + RotScaleDistortion: translation, rotation and scale (common between x and y)<br/> + DoubleRotScaleDistortion: one RotScaleDistortion for each CCD</li> </ul> <p>When running reduceArc (which calls fitDetectorMap), we have the measured distortions from the lines and traces relative to the base model. We iteratively:</p> <ul> <li>Set all the slit offsets to the mean of the measured offsets</li> <li>Fit a distortion field:<br/> + PolynomialDistortion for arm=n (monolithic detector)<br/> + DoubleDistortion for arm=b and arm=r (two CCDs)</li> <li>Iteratively measure the slit offsets per fiber from the residuals</li> </ul> <p>When running reduceExposure (which calls adjustDetectorMap), we have the measured distortions from the lines and traces relative to the best detectorMap. We iteratively fit a distortion field (RotScaleDistortion for arm=n monolithic detector; DoubleDistortion for arm=b and arm=r two CCDs).</p> <p>Also added <tt>MosaicPolynomialDistortion</tt>, which I think is more the sort of distortion model RHL was thinking (single distortion field, but with additional affine transform for the one of the CCDs) and fixed a few fitting things.</p> <p>Merged to master.</p> Development Rank 0|zzszcn: Sprint Eng13Oct