https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1285 DRP 2-D Pipeline <p><tt>generateCommands.py</tt> should accept and pass though the task <tt>-<del>doraise</tt> and <tt></del><del>longlog</tt> arguments. Currently, <tt></del><del>doraise</tt> is always added, and <tt></del>-longlog</tt> cannot be. Yes, we know that that Gen3 will require major changes, but those would help substantially in the meanwhile.</p> PIPE2D-1285

Allow generateCommands.py to control --doraise and --longlog

Task Normal Done Done sogo.mineo cloomis Tue, 15 Aug 2023 20:30:09 +0000 Thu, 24 Aug 2023 00:15:36 +0000 Thu, 24 Aug 2023 00:15:36 +0000 pfs_pipe2d 0 3 <p>Should I make both -<del>doraise and --longlog optional, or always use them forcibly? Though I have added </del>-doraise to the command lines, I don't exactly know the effect of this option.</p> <p>Another question: What is the argument of &#45;&#45;longlog option?</p> <p><tt>&#45;&#45;doraise</tt> causes iteration over the <tt>dataId</tt> to immediately cease, and to raise the exception (allowing it to be trapped if you run under <tt>pdb</tt> with a single process). If you leave it off, the command will continue iterating and log at the end how many failed.<br/> <tt>&#45;&#45;longlog</tt> requires an argument, but that argument isn't respected at all (a bug). I think people often put <tt>&#45;&#45;longlog 1</tt>, I often use <tt>&#45;&#45;longlog FOO</tt>.</p> <p>Thanks. As for <tt>&#45;&#45;longlog</tt>, I think it will be enough if I always add <tt>&#45;&#45;longlog=1</tt> to the command lines.<br/> As for <tt>&#45;&#45;doraise</tt>, I think all I have to do is to omit <tt>&#45;&#45;doraise</tt> when <tt>generateCommands.py</tt> is called with <tt>&#45;&#45;allowErrors</tt> option, which already exists. Is it correct?</p> <p>I think that's right.</p> <p>Could you review the PR? I have made --doraise controllable according to the request, but I have decided to always use --longlog option.</p> <p>Merged. Thanks for reviewing.</p> Development Rank 0|zzsz8n: Reviewers price