https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-128 DRP 2-D Pipeline <p>In <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-125" title="Fixups from onboarding" class="issue-link" data-issue-key="PIPE2D-125"><del>PIPE2D-125</del></a>, I removed an extra layer in the <tt>config</tt> directory, but neglected to modify the configuration files to adapt to this change.</p> PIPE2D-128

Fix config directories

Bug Major Done Done price price Tue, 22 Nov 2016 22:53:17 +0000 Wed, 23 Nov 2016 20:11:43 +0000 Wed, 23 Nov 2016 20:11:43 +0000 0 2 <p>Sorry, <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=aritter" class="user-hover" rel="aritter">aritter</a>, I have another for you. This is a fix to problems I introduced in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-125" title="Fixups from onboarding" class="issue-link" data-issue-key="PIPE2D-125"><del>PIPE2D-125</del></a>. Would you please have a look?</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> price@price-laptop:~/PFS/obs_pfs (tickets/PIPE2D-128=) $ git sub commit 5d52f2b37c45a02e98330335f28861fac27b7af0 Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Tue Nov 22 18:03:49 2016 -0500 config: remove excess directory The directory has been removed (PIPE2D-125) but <span class="code-keyword">this</span> change wasn't reflected in the config files. config/bias.py | 2 +- config/flat.py | 2 +- config/processCcd.py | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) commit d910c7e8ae31b75a5489974f99372bf2fde52312 Author: Paul Price &lt;price@astro.princeton.edu&gt; Date: Tue Nov 22 18:04:46 2016 -0500 config: cleanup Remove blank and commented lines, unnecessary imports. config/arc.py | 14 -------------- config/bias.py | 1 - config/flat.py | 1 - config/isr.py | 4 ---- config/processCcd.py | 5 ----- 5 files changed, 25 deletions(-) </pre> </div></div> <p>Why is e.g. `constructBias.py` still looking for config files in `config/pfs/`?</p> <p>`root INFO: Config override file does not exist: '/Users/azuri/stella-git/obs_pfs/config/pfs/bias.py'`</p> <p>Otherwise looks fine.<br/> Note: I also updated drp_stella/examples/runPipeline.py and drp_stella/sphinx/user/getting_started.rst to remove `--camera PFS` after the changes to `genCalibRegistry.py` in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-125" title="Fixups from onboarding" class="issue-link" data-issue-key="PIPE2D-125"><del>PIPE2D-125</del></a>. Did this straight on master though as it is pretty much only a documentation thing. Maybe should have filed a ticket though...</p> <p>Also, there is still one file `constructFiberFlat.py` in `obs_pfs/config/pfs`. Missed that in the ticket <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-125" title="Fixups from onboarding" class="issue-link" data-issue-key="PIPE2D-125"><del>PIPE2D-125</del></a> review...</p> <p>The <tt>CmdLineTask</tt> framework looks in both <tt>config</tt> and <tt>config/pfs</tt> (because it has no idea whether there's two cameras in that package or not), and warns if either doesn't exist.</p> <p>I added another commit to move <tt>constructFiberFlat.py</tt> down.</p> <p>Merged to master.</p> Development Rank 0|ii012f: Reviewers aritter