https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1268 DRP 2-D Pipeline <p>something looks very wrong with the new r1 DetectorMap. Note the double line, and many of the pixels seem to be associated with 316 according to <tt>findFiberId</tt>, and in fact I can get it to crash (see jupyter screen shot <span class="image-wrap" style=""><a id="16166_thumb" href="https://pfspipe.ipmu.jp/jira/secure/attachment/16166/16166_image+%2815%29.png" title="image (15).png" file-preview-type="image" file-preview-id="16166" file-preview-title="image (15).png"><img src="https://pfspipe.ipmu.jp/jira/secure/thumbnail/16166/_thumb_16166.png" style="border: 0px solid black" /></a></span> ).</p> <p>The problem is that 316 is in the wrong place (see attachments), although its <tt>spatialOffset</tt> is 0.0. </p> PIPE2D-1268

Fibre 316 is in the wrong place in r1

Story Normal Done Done price rhl engRun12 Fri, 21 Jul 2023 12:50:05 +0000 Tue, 25 Jul 2023 14:19:09 +0000 Tue, 25 Jul 2023 14:19:09 +0000 0 2 <p>This is intrinsic to the base detectorMap from the simulator, and has been present ever since we included the engineering fibers: interpolating across the chip gap led to an inaccurate position. I have a fix for the detectorMap generation in the simulator. Then I need to generate new base detectorMaps for drp&#95;pfs&#95;data and correct the existing detectorMaps in the current calib.</p> <p>Merged drp&#95;instmodel and drp&#95;pfs&#95;data.</p> <p>Updated <tt>CALIB-2023-07-v2</tt> detectorMaps and renamed to <tt>CALIB-2023-07-v3</tt>:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> (lsst-scipipe-3.0.0) price@pfsa-usr02-gb:/work/price/pipe2d-1268 $ cp -r /work/drp/CALIB-2023-07-v2 . from glob <span class="code-keyword">import</span> glob <span class="code-keyword">import</span> numpy as np from pfs.drp.stella <span class="code-keyword">import</span> DetectorMap from pfs.utils.fiberids <span class="code-keyword">import</span> FiberIds def interpolate(x, x1, x2, y1, y2): weight2 = (x - x1)/(x2 - x1) weight1 = 1.0 - weight2 <span class="code-keyword">return</span> y1*weight1 + y2*weight2 def fixDetectorMap(detMap): base = detMap distortion = None <span class="code-keyword">if</span> hasattr(detMap, <span class="code-quote">"getBase"</span>): base = detMap.getBase() distortion = detMap.getDistortion() fibers = FiberIds() isEngFiber = np.isin(detMap.fiberId, fibers.fiberId[fibers.scienceFiberId == fibers.ENGINEERING]) engFibers = detMap.fiberId[isEngFiber] scienceFibers = detMap.fiberId[~isEngFiber] <span class="code-keyword">for</span> fiberId in engFibers: lowIndex, highIndex = np.argpartition(np.abs(scienceFibers - fiberId), [0, 1])[:2] low = scienceFibers[lowIndex] high = scienceFibers[highIndex] xCenterKnots = interpolate(fiberId, low, high, base.getXCenterSpline(low).getX(), base.getXCenterSpline(high).getX()) xCenterValues = interpolate(fiberId, low, high, base.getXCenterSpline(low).getY(), base.getXCenterSpline(high).getY()) wavelengthKnots = interpolate(fiberId, low, high, base.getWavelengthSpline(low).getX(), base.getWavelengthSpline(high).getX()) wavelengthValues = interpolate(fiberId, low, high, base.getWavelengthSpline(low).getY(), base.getWavelengthSpline(high).getY()) base.setXCenter(fiberId, xCenterKnots, xCenterValues) base.setWavelength(fiberId, wavelengthKnots, wavelengthValues) <span class="code-keyword">if</span> distortion is None: <span class="code-keyword">return</span> base <span class="code-keyword">return</span> type(detMap)(base, distortion, detMap.visitInfo, detMap.metadata) <span class="code-keyword">for</span> filename in glob(<span class="code-quote">"/work/price/pipe2d-1268/CALIB-2023-07-v2/DETECTORMAP/pfsDetectorMap-*.fits"</span>): detMap = DetectorMap.readFits(filename) detMap = fixDetectorMap(detMap) detMap.writeFits(filename) (lsst-scipipe-3.0.0) price@pfsa-usr02-gb:/work/drp $ cp -r /work/price/pipe2d-1268/CALIB-2023-07-v2 CALIB-2023-07-v3 (lsst-scipipe-3.0.0) price@pfsa-usr02-gb:/work/drp $ rm CALIB (lsst-scipipe-3.0.0) price@pfsa-usr02-gb:/work/drp $ ln -s CALIB-2023-07-v3 CALIB (lsst-scipipe-3.0.0) price@pfsa-usr02-gb:/work/drp/CALIB-2023-07-v3 $ rm -r DETECTORMAP-bad-r1-316/ </pre> </div></div> Development Rank 0|zzsyx3: