<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:05:13 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-1265] n3 unable to measure aperture corrections using Ar spectra</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1265</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;the n3 DetectorMap still seems to have problems. The command&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
reduceExposure.py /work/drp --calib /work/drp/CALIB --rerun rhl/eng-2023-07 -c isr.doFlat=False isr.doFlatNir=False doAdjustDetectorMap=True doMeasureLines=True --id visit=96925 arm=n spectrograph=3
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;fails, although there are quite a few lines in this (Argon) spectrum.&lt;/p&gt;

&lt;p&gt;The error is&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
reduceExposure.readLineList INFO: Filtered line lists, keeping species {&lt;span class=&quot;code-quote&quot;&gt;&apos;ArI&apos;&lt;/span&gt;}.
reduceExposure.centroidLines INFO: Measured 15090 line centroids
reduceExposure.centroidTraces INFO: Measured 11457 centroids &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; 616 traces
reduceExposure.adjustDetectorMap INFO: Final fit: chi2=91050.655441 dof=6179 xRMS=0.179240 yRMS=0.231107 (0.018896 nm) xSoften=0.179387 ySoften=0.000000 from 5879/10337 lines
reduceExposure.adjustDetectorMap INFO: Fit quality from reserved lines: chi2=10495911.585279 xRMS=2.302150 yRMS=0.250867 (0.020512 nm) xSoften=nan ySoften=nan from 1149 lines (10.0%)
reduceExposure.adjustDetectorMap INFO: Softened fit: chi2=8046.568473 dof=6179 xRMS=0.190672 yRMS=0.231775 (0.018951 nm) xSoften=0.179025 ySoften=0.000000 from 1149 lines
reduceExposure.adjustDetectorMap INFO: Softened fit quality from reserved lines: chi2=2798182.905496 xRMS=1.850856 yRMS=0.252046 (0.020608 nm) xSoften=nan ySoften=nan from 1149 lines
reduceExposure.adjustDetectorMap INFO: Final fit: chi2=124552.676454 dof=7121 xRMS=0.190180 yRMS=0.238217 (0.019477 nm) xSoften=0.195424 ySoften=0.000000 from 6887/10337 lines
reduceExposure.adjustDetectorMap INFO: Fit quality from reserved lines: chi2=4083351.546211 xRMS=0.299657 yRMS=0.215840 (0.017648 nm) xSoften=0.584591 ySoften=nan from 1149 lines (10.0%)
reduceExposure.adjustDetectorMap INFO: Softened fit: chi2=8586.509074 dof=7121 xRMS=0.202688 yRMS=0.239126 (0.019552 nm) xSoften=0.193465 ySoften=0.000000 from 1149 lines
reduceExposure.adjustDetectorMap INFO: Softened fit quality from reserved lines: chi2=4222416.705908 xRMS=0.277735 yRMS=0.216072 (0.017667 nm) xSoften=0.532115 ySoften=nan from 1149 lines
reduceExposure.adjustDetectorMap INFO: Final result: chi2=134586.912645 dof=7121 xRMS=0.195130 yRMS=0.445191 xSoften=0.202842 ySoften=0.000000 from 6887 lines
reduceExposure.adjustDetectorMap INFO: Stats &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; ArI: chi2=7287.992431 dof=516 xRMS=0.270384 yRMS=0.445191 xSoften=0.174193 ySoften=0.297691 from 258 lines
reduceExposure.adjustDetectorMap INFO: Stats &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; Trace: chi2=127298.920213 dof=6629 xRMS=0.194281 yRMS=nan xSoften=0.204488 ySoften=0.000000 from 6629 lines
reduceExposure.adjustDetectorMap INFO: Stats &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; fiberId=1306: chi2=248.997118 dof=7 xRMS=0.292737 yRMS=nan xSoften=0.241155 ySoften=0.000000 from 7 lines (7 Trace)
reduceExposure.adjustDetectorMap INFO: Stats &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; fiberId=1442: chi2=228.998997 dof=16 xRMS=0.150777 yRMS=nan xSoften=0.143070 ySoften=0.000000 from 16 lines (16 Trace)
reduceExposure.adjustDetectorMap INFO: Stats &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; fiberId=1579: chi2=15.715469 dof=5 xRMS=0.089503 yRMS=nan xSoften=0.081027 ySoften=0.000000 from 5 lines (5 Trace)
reduceExposure.adjustDetectorMap INFO: Stats &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; fiberId=1800: chi2=390.167935 dof=18 xRMS=0.200247 yRMS=nan xSoften=0.210373 ySoften=0.000000 from 18 lines (18 Trace)
reduceExposure.adjustDetectorMap INFO: Stats &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; fiberId=1953: chi2=175.966506 dof=3 xRMS=0.521229 yRMS=nan xSoften=0.668233 ySoften=0.000000 from 3 lines (3 Trace)
reduceExposure FATAL: Failed on dataIds=[{&lt;span class=&quot;code-quote&quot;&gt;&apos;visit&apos;&lt;/span&gt;: 96925, &lt;span class=&quot;code-quote&quot;&gt;&apos;arm&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;n&apos;&lt;/span&gt;, &lt;span class=&quot;code-quote&quot;&gt;&apos;spectrograph&apos;&lt;/span&gt;: 3, &lt;span class=&quot;code-quote&quot;&gt;&apos;dateObs&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;2023-07-20&apos;&lt;/span&gt;, &lt;span class=&quot;code-quote&quot;&gt;&apos;site&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;S&apos;&lt;/span&gt;, &lt;span class=&quot;code-quote&quot;&gt;&apos;category&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;B&apos;&lt;/span&gt;, &lt;span class=&quot;code-quote&quot;&gt;&apos;field&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;GE_EN1_P1_PA_90&apos;&lt;/span&gt;, &lt;span class=&quot;code-quote&quot;&gt;&apos;ccd&apos;&lt;/span&gt;: 8, &lt;span class=&quot;code-quote&quot;&gt;&apos;filter&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;n&apos;&lt;/span&gt;, &lt;span class=&quot;code-quote&quot;&gt;&apos;expTime&apos;&lt;/span&gt;: 60.0, &lt;span class=&quot;code-quote&quot;&gt;&apos;dataType&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;COMPARISON&apos;&lt;/span&gt;, &lt;span class=&quot;code-quote&quot;&gt;&apos;taiObs&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;2023-07-20T07:42:40.982&apos;&lt;/span&gt;, &lt;span class=&quot;code-quote&quot;&gt;&apos;pfsDesignId&apos;&lt;/span&gt;: 1562097688427952981, &lt;span class=&quot;code-quote&quot;&gt;&apos;slitOffset&apos;&lt;/span&gt;: 0.0}]: RuntimeError: No good points
Traceback (most recent call last):
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/cmdLineTask.py&quot;&lt;/span&gt;, line 436, in __call__
    result = self.runTask(task, dataRef, kwargs)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/cmdLineTask.py&quot;&lt;/span&gt;, line 504, in runTask
    &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; task.runDataRef(dataRef, **kwargs)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/reduceExposure.py&quot;&lt;/span&gt;, line 278, in runDataRef
    calibs = self.getSpectralCalibs(sensorRef, exposure, pfsConfig)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/reduceExposure.py&quot;&lt;/span&gt;, line 580, in getSpectralCalibs
    phot = self.photometerLines.run(exposure, lines[notTrace], detectorMap, pfsConfig, fiberTraces)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/photometerLines.py&quot;&lt;/span&gt;, line 99, in run
    phot = self.photometerLines(exposure, referenceLines, detectorMap, pfsConfig, fiberTraces)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/photometerLines.py&quot;&lt;/span&gt;, line 176, in photometerLines
    apCorr = self.apertureCorrection.run(exposure, pfsConfig, detectorMap, lines)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/apertureCorrections.py&quot;&lt;/span&gt;, line 125, in run
    apCorr = self.fit.run(corrections, pfsConfig, minWavelength=minWavelength,
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/home/rhl/PFS/drp/stella/python/pfs/drp/stella/fitFocalPlane.py&quot;&lt;/span&gt;, line 109, in run
    raise RuntimeError(&lt;span class=&quot;code-quote&quot;&gt;&quot;No good points&quot;&lt;/span&gt;)
RuntimeError: No good points
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;If I don&apos;t try to update the DetectorMaps that n1 and n3 don&apos;t agree, which is probably a clue.&#160; &lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;a id=&quot;16163_thumb&quot; href=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/16163/16163_Spectra+%2820%29.png&quot; title=&quot;Spectra (20).png&quot; file-preview-type=&quot;image&quot; file-preview-id=&quot;16163&quot; file-preview-title=&quot;Spectra (20).png&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/thumbnail/16163/_thumb_16163.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/a&gt;&lt;/span&gt; &lt;/p&gt;</description>
                <environment></environment>
        <key id="23731">PIPE2D-1265</key>
            <summary>n3 unable to measure aperture corrections using Ar spectra</summary>
                <type id="10001" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10515&amp;avatarType=issuetype">Story</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="price">price</assignee>
                                    <reporter username="rhl">rhl</reporter>
                        <labels>
                            <label>engRun12</label>
                    </labels>
                <created>Fri, 21 Jul 2023 12:33:54 +0000</created>
                <updated>Tue, 1 Aug 2023 19:28:44 +0000</updated>
                            <resolved>Tue, 1 Aug 2023 19:28:44 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                <comments>
                            <comment id="34094" author="price" created="Fri, 21 Jul 2023 19:35:00 +0000"  >&lt;p&gt;This is a failure to measure aperture corrections (required for line flux measurements) rather than a failure to adjust the detectorMap. As a workaround, setting &lt;tt&gt;doMeasureLines=False&lt;/tt&gt; should allow the command to complete successfully.&lt;/p&gt;</comment>
                            <comment id="34096" author="rhl" created="Sat, 22 Jul 2023 01:08:09 +0000"  >&lt;p&gt;Fair enough &#8211; I often do that. &#160;Agreed to lower priority&lt;/p&gt;</comment>
                            <comment id="34231" author="price" created="Mon, 31 Jul 2023 18:48:36 +0000"  >&lt;p&gt;The above command (without the workaround) now works. My guess is that the aperture corrections were failing due to a rubbish detectorMap.&lt;/p&gt;

&lt;p&gt;Before:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
reduceExposure.adjustDetectorMap INFO: Final result: chi2=134586.912645 dof=7121 xRMS=0.195130 yRMS=0.445191 xSoften=0.202842 ySoften=0.000000 from 6887 lines
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Now:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
reduceExposure.adjustDetectorMap INFO: Final result: chi2=84790.380899 dof=18540 xRMS=0.106197 yRMS=0.080685 xSoften=0.082549 ySoften=0.005221 from 14590 lines
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;We now have a much smaller chi^2 from a larger set of lines.&lt;/p&gt;

&lt;p&gt;I propose to close this as Done.&lt;/p&gt;</comment>
                            <comment id="34236" author="price" created="Tue, 1 Aug 2023 19:28:44 +0000"  >&lt;p&gt;No objections, so closing.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="16163" name="Spectra (20).png" size="2095655" author="rhl" created="Fri, 21 Jul 2023 12:31:52 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|zzsywf:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>