https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-124 DRP 2-D Pipeline <p>Please use the new redFiberTrace.fits file, which includes the (fiber#,y)-&gt;wavelength map, in reduceArcTask.py and the tests in drp_stella. This includes small changes in FiberTraces.h/cc assignITrace and findITrace as there is no yCenter column any more in the new file</p> PIPE2D-124

include the new redFiberTraces.fits file in the DRP

Story Major Won't Fix Won't Fix aritter aritter Tue, 15 Nov 2016 03:26:16 +0000 Mon, 23 Jan 2017 20:58:08 +0000 Mon, 23 Jan 2017 20:58:08 +0000 0 3 <p>This confuses me: isn't the point of <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-11" title="Create or adapt file to include per-fiber+row wavelengths." class="issue-link" data-issue-key="DAMD-11"><del>DAMD-11</del></a> to avoid publishing the <b>one-time hack</b> <tt>redFiberTraces.fits</tt>? If we get <em>any</em> formal wavelength solution persistence then we can forget that we ever needed this file.</p> <p>Until <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-11" title="Create or adapt file to include per-fiber+row wavelengths." class="issue-link" data-issue-key="DAMD-11"><del>DAMD-11</del></a> is implemented we still want the redFiberTraces.fits to make the tests pass again. As the format has changed compared to the old version of the file some code changes are required for which a ticket is needed.</p> <p>Ready for review once <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-119" title="Update test data in drp_stella_data" class="issue-link" data-issue-key="PIPE2D-119"><del>PIPE2D-119</del></a> is merged into master. Tests in Spectra.py pass again.</p> <p>Changes are in drp_stella and obs_pfs tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-124" title="include the new redFiberTraces.fits file in the DRP" class="issue-link" data-issue-key="PIPE2D-124"><del>PIPE2D-124</del></a></p> <p>Per our meeting of 2017-01-09, <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=aritter" class="user-hover" rel="aritter">aritter</a> will check if this ticket is actually still necessary. Since we expect that this work to be rendered obsolete by <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-11" title="Create or adapt file to include per-fiber+row wavelengths." class="issue-link" data-issue-key="DAMD-11"><del>DAMD-11</del></a>, this will be marked as "won't fix" unless it's actively breaking tests in the short term.</p> <p>It turns out that the old file RedFiberPixels.fits.gz is sufficient since the geometry bug was fixed in Craig's simulations. However I recommend adopting the remaining changes in drp_stella tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-124" title="include the new redFiberTraces.fits file in the DRP" class="issue-link" data-issue-key="PIPE2D-124"><del>PIPE2D-124</del></a> as they are improvements to the code. Part of the changes undo changes we made when the new test data containing the geometry bug in the simulations were introduced. Another part removes un-used imports and variables. We could rename the issue and submit it to review, which should be a quick one...</p> <p>Given the above, we agreed at our meeting of 2017-01-18 that this ticket should be closed as "won't fix", and we need three new tickets to take care of the work which currently exists on the <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-124" title="include the new redFiberTraces.fits file in the DRP" class="issue-link" data-issue-key="PIPE2D-124"><del>PIPE2D-124</del></a> ticket branch (which is worth saving).</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=aritter" class="user-hover" rel="aritter">aritter</a> will file those tickets then mark this as "won't fix".</p> <p>Removing the `yCenters` parameter from `assignITrace` and `findITrace` is done as part of <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-138" title="Fix FiberId identification" class="issue-link" data-issue-key="PIPE2D-138"><del>PIPE2D-138</del></a>.<br/> Removing unused import from testDrp.py will be done in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-69" title="tests/testDrp.py fails without returning an error code on os/x 10.11" class="issue-link" data-issue-key="PIPE2D-69"><del>PIPE2D-69</del></a>.<br/> Filed ticket <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-149" title="quick-start guide: replace reduceArcRefSpec with reduceArc" class="issue-link" data-issue-key="PIPE2D-149"><del>PIPE2D-149</del></a> to replace `reduceArcRefSpec.py` with `reduceArc.py` in the quick-start guide.</p> Blocks PIPE2D-119 Relates PIPE2D-149 Development Rank 0|ii00v2:yr Reviewers cloomis Sprint 2014-16 Story Points 1.0