https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1233 DRP 2-D Pipeline <p>We currently have a flat-field image for n1 only. We want to apply the flat for n1 without applying a flat in b/r, using a single configuration setting (so we can achieve this with a single call to <tt>reduceExposure.py</tt> or <tt>detrend.py</tt>).</p> PIPE2D-1233

Allow flat-fielding for n while not flat-fielding b/r

Story Normal Done Done price price Tue, 6 Jun 2023 19:37:18 +0000 Thu, 8 Jun 2023 18:21:48 +0000 Thu, 8 Jun 2023 18:21:47 +0000 0 2 <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a>, I've added a <tt>doFlatNir</tt> configuration parameter to ISR. The NIR will have the flat-field applied if either <tt>doFlat</tt> or <tt>doFlatNir</tt> is set. For current Subaru operations, we'll set <tt>doFlat=False doFlatNir=True</tt>, which will result in the <tt>n</tt> arm having the flat applied and the <tt>b</tt> and <tt>r</tt> arms not having a flat applied. Are you satisfied with this solution?</p> <p>How about <tt>doFlatArms="brm"</tt> instead? </p> <p>I think I could make that work, by overriding the <tt>flatCorrection</tt> method of <tt>IsrTask</tt>, but there would be one annoyance: the log message, "Applying flat correction", originates from the <tt>run</tt> method, which we do not want to override (because it's very very long and involved). Then if <tt>doFlat=True</tt> but the arm being processed is not in the <tt>doFlatArms</tt> list, you would get a log message "Applying flat correction" even though we would intercept and disable the application of the flat. We could log our own message ("Hey, just kidding before, we're not actually applying the flat"), but I fear the confusion that would result.</p> <p>An alternative to all of this would be to generate fake flats for the optical arms that are unity everywhere, and then we wouldn't have to hack around things in the code.</p> <p>Hopefully this state of affairs won't last much longer, and we'll get real flats for the optical arms in the next run.</p> <p>Spoke to <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a>, who agreed that this current solution isn't ideal (we'd prefer being able to specify the arms to be flat-fielded) but it's good enough given the limitations.</p> <p>Merged to master.</p> Development Rank 0|zzsxbj: Reviewers rhl