https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1163 DRP 2-D Pipeline <p>Per <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1863" title="Add a few FITS header to pfsConfig file" class="issue-link" data-issue-key="INSTRM-1863"><del>INSTRM-1863</del></a>, we need to add a handful of cards to the PHDU of the pfsConfig files.</p> <p>From Slack discussions, I believe we agreed to add a <tt>header=[Dict<span class="error">&#91;name, (value, comment)&#93;</span>]</tt> argument to the <tt>pfsConfig</tt> constructor. When the <tt>.write()</tt> method is called, those cards will be written to the PHDU.</p> <p>Side note: for now we will add a <tt>PROP-ID</tt> proposal card. Once the requirements are understood, there will likely be a new <tt>proposal</tt> column in the config table, giving one proposal per fiber.</p> PIPE2D-1163

Allow adding FITS cards to pfsConfig PHDU

Task Normal Done Done Unassigned cloomis Wed, 15 Feb 2023 21:56:24 +0000 Wed, 22 Feb 2023 17:41:30 +0000 Wed, 22 Feb 2023 17:41:30 +0000 datamodel 0 2 <p>One obnoxiousness is that we need to add a <tt>DATE-OBS</tt> card to the pfsConfig PHDU. <b>Actually</b> making that match the PFS<span class="error">&#91;AB&#93;</span> files would be hard. Also not really useful: the <b>visit</b> is the thing which groups all the components together.</p> <p>So I think `DATE-OBS` should be added by <tt>PfsConfig._writeImp()</tt>. <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a>?</p> <p>Is there a reason that can't be in the <tt>header</tt>?</p> <p>No. I probably just wanted to make someone else lie about the date. Nevermind.</p> <p>We are required to add CHECKSUM/DATASUM. I think that just means adding <tt>checksum=True</tt> to the <tt>fits.writeto()</tt> call. Objections?</p> <p>Do we need the FiberType and TargetStatus definitions used in the <tt>fiberStatus</tt> table to be in the PHDU? Can those be added to the header for the <tt>DESIGN</tt> HDU <b>after</b> writing the PHDU? We have been given a provisional pass on putting HIERARCH in the PHDUs, but can we remove them entirely without breaking code? Looks to me that they are <b>read</b> from the <tt>DESIGN</tt> HDU, so do not need to be written to the PHDU as well.</p> <p>I'm fine with adding <tt>CHECKSUM</tt> (we should do that everywhere) and moving the <tt>FiberStatus</tt> and <tt>TargetType</tt> to the table HDU.</p> Relates INSTRM-1863 Development Rank 0|zzsw7z: