https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1159 DRP 2-D Pipeline <p>Please always write <tt>detectorMap_used</tt> even if it's identical to <tt>detectorMap</tt>; this allows users to get into the habit of always using the best available map</p> PIPE2D-1159

Please always provide a detectorMap_used file

Story Normal Done Done price rhl Sat, 11 Feb 2023 16:32:04 +0000 Mon, 13 Feb 2023 19:06:41 +0000 Mon, 13 Feb 2023 19:06:41 +0000 0 3 <p>Could you please give an example of when a <tt>detectorMap_used</tt> is not available after running <tt>reduceExposure</tt>?</p> <p>I don't see any in /work/rhl/rerun/rhl/tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1136" title="Correctly subtract the dark signal seen on r3" class="issue-link" data-issue-key="PIPE2D-1136"><del>PIPE2D-1136</del></a> on the Hilo server.</p> <p>I <em>think</em> that the magic config is <tt>photometerLines.doApertureCorrection=False</tt> although that seems unlikely.</p> <p>Ah, it's only written if <tt>doAdjustDetectorMap</tt> is <tt>True</tt>: <a href="https://github.com/Subaru-PFS/drp_stella/blob/master/python/pfs/drp/stella/reduceExposure.py#L538" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/drp_stella/blob/master/python/pfs/drp/stella/reduceExposure.py#L538</a><br/> That's easily fixed. (But why would you run without that?)</p> <p>Because, at times, <tt>doAdjustDetectorMap</tt> has made matters worse. I'm sure that'll never happen again</p> <p>I usually turn it off in hilo for the "on the fly" reduction, because it's much faster without.<br/> Also, we were taking mostly windowed exposure and wasn't sure if the fitting code is able to handle that.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=arnaud.lefur" class="user-hover" rel="arnaud.lefur">arnaud.lefur</a>, would you like to take this for a test drive before I merge?</p> <p>Yes, just did a quick test and it worked <img class="emoticon" src="https://pfspipe.ipmu.jp/jira/images/icons/emoticons/thumbs_up.png" height="16" width="16" align="absmiddle" alt="" border="0"/>.</p> <p>Merged to master.</p> Development Rank 0|zzsw6f: Reviewers arnaud.lefur