<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:03:23 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-1147] flux calibration fails for m-band data</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1147</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;Reducing data set of GA targets with m-band, flux calibration fails in the middle with the error message below:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
INFO  2023-01-16T16:39:45.573-1000 fitPfsFluxReference ({&lt;span class=&quot;code-quote&quot;&gt;&apos;visit&apos;&lt;/span&gt;: 83219, &lt;span class=&quot;code-quote&quot;&gt;&apos;dateObs&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;2022-11-21&apos;&lt;/span&gt;})(fitPfsFluxReference.py:290)- Fitting models to spectra (takes some time)...
INFO  2023-01-16T17:18:37.548-1000 fitPfsFluxReference ({&lt;span class=&quot;code-quote&quot;&gt;&apos;visit&apos;&lt;/span&gt;: 83219, &lt;span class=&quot;code-quote&quot;&gt;&apos;dateObs&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;2022-11-21&apos;&lt;/span&gt;})(fitPfsFluxReference.py:322)- Making reference spectra by interpolation
WARN  2023-01-16T17:19:56.388-1000 astropy ({&lt;span class=&quot;code-quote&quot;&gt;&apos;visit&apos;&lt;/span&gt;: 83219, &lt;span class=&quot;code-quote&quot;&gt;&apos;dateObs&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;2022-11-21&apos;&lt;/span&gt;})(logger.py:211)- VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_ABSENT_FIBER&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created.
WARN  2023-01-16T17:19:56.390-1000 astropy ({&lt;span class=&quot;code-quote&quot;&gt;&apos;visit&apos;&lt;/span&gt;: 83219, &lt;span class=&quot;code-quote&quot;&gt;&apos;dateObs&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;2022-11-21&apos;&lt;/span&gt;})(logger.py:211)- VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_BAD_FIBER&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created.
WARN  2023-01-16T17:19:56.390-1000 astropy ({&lt;span class=&quot;code-quote&quot;&gt;&apos;visit&apos;&lt;/span&gt;: 83219, &lt;span class=&quot;code-quote&quot;&gt;&apos;dateObs&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;2022-11-21&apos;&lt;/span&gt;})(logger.py:211)- VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_DEFICIENT_BBFLUXES&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created.
WARN  2023-01-16T17:19:56.391-1000 astropy ({&lt;span class=&quot;code-quote&quot;&gt;&apos;visit&apos;&lt;/span&gt;: 83219, &lt;span class=&quot;code-quote&quot;&gt;&apos;dateObs&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;2022-11-21&apos;&lt;/span&gt;})(logger.py:211)- VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_FITBBSED_FAILED&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created.
WARN  2023-01-16T17:19:56.392-1000 astropy ({&lt;span class=&quot;code-quote&quot;&gt;&apos;visit&apos;&lt;/span&gt;: 83219, &lt;span class=&quot;code-quote&quot;&gt;&apos;dateObs&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;2022-11-21&apos;&lt;/span&gt;})(logger.py:211)- VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_ESTIMATERADIALVELOCITY_FAILED&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created.
WARN  2023-01-16T17:19:56.393-1000 astropy ({&lt;span class=&quot;code-quote&quot;&gt;&apos;visit&apos;&lt;/span&gt;: 83219, &lt;span class=&quot;code-quote&quot;&gt;&apos;dateObs&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;2022-11-21&apos;&lt;/span&gt;})(logger.py:211)- VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_FITMODELS_FAILED&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created.
WARN  2023-01-16T17:19:56.394-1000 astropy ({&lt;span class=&quot;code-quote&quot;&gt;&apos;visit&apos;&lt;/span&gt;: 83219, &lt;span class=&quot;code-quote&quot;&gt;&apos;dateObs&apos;&lt;/span&gt;: &lt;span class=&quot;code-quote&quot;&gt;&apos;2022-11-21&apos;&lt;/span&gt;})(logger.py:211)- VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_MAKEREFERENCESPECTRA_FAILED&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created.
/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/drp_stella/w.2023.02/python/pfs/drp/stella/fitReference.py:81: IntegrationWarning: The maximum number of subdivisions (100) has been achieved.
  If increasing the limit yields no improvement it is advised to analyze
  the integrand in order to determine the difficulties.  If the position of a
  local difficulty can be determined (singularity, discontinuity) one will
  probably gain from splitting up the interval and calling the integrator
  on the subranges.  Perhaps a special-purpose integrator should be used.
  &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; scipy.integrate.quad(function, self.wavelength[0], self.wavelength[-1],
/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/drp_stella/w.2023.02/python/pfs/drp/stella/fitReference.py:81: IntegrationWarning: The maximum number of subdivisions (100) has been achieved.
  If increasing the limit yields no improvement it is advised to analyze
  the integrand in order to determine the difficulties.  If the position of a
  local difficulty can be determined (singularity, discontinuity) one will
  probably gain from splitting up the interval and calling the integrator
  on the subranges.  Perhaps a special-purpose integrator should be used.
  &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; scipy.integrate.quad(function, self.wavelength[0], self.wavelength[-1],
WARNING: VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_ABSENT_FIBER&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created. [astropy.io.fits.card]
WARNING: VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_BAD_FIBER&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created. [astropy.io.fits.card]
WARNING: VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_DEFICIENT_BBFLUXES&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created. [astropy.io.fits.card]
WARNING: VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_FITBBSED_FAILED&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created. [astropy.io.fits.card]
WARNING: VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_ESTIMATERADIALVELOCITY_FAILED&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created. [astropy.io.fits.card]
WARNING: VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_FITMODELS_FAILED&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created. [astropy.io.fits.card]
WARNING: VerifyWarning: Keyword name &lt;span class=&quot;code-quote&quot;&gt;&apos;MP_MAKEREFERENCESPECTRA_FAILED&apos;&lt;/span&gt; is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created. [astropy.io.fits.card]
multiprocessing.pool.RemoteTraceback:
&quot;&quot;&quot;
Traceback (most recent call last):
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-3.0.0/lib/python3.8/site-packages/scipy/optimize/_minpack_py.py&quot;&lt;/span&gt;, line 809, in curve_fit
    transform = cholesky(sigma, lower=True)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-3.0.0/lib/python3.8/site-packages/scipy/linalg/_decomp_cholesky.py&quot;&lt;/span&gt;, line 88, in cholesky
    c, lower = _cholesky(a, lower=lower, overwrite_a=overwrite_a, clean=True,
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-3.0.0/lib/python3.8/site-packages/scipy/linalg/_decomp_cholesky.py&quot;&lt;/span&gt;, line 37, in _cholesky
    raise LinAlgError(&lt;span class=&quot;code-quote&quot;&gt;&quot;%d-th leading minor of the array is not positive &quot;&lt;/span&gt;
numpy.linalg.LinAlgError: 16-th leading minor of the array is not positive definiteThe above exception was the direct cause of the following exception:Traceback (most recent call last):
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-3.0.0/lib/python3.8/multiprocessing/pool.py&quot;&lt;/span&gt;, line 125, in worker
    result = (True, func(*args, **kwds))
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-3.0.0/lib/python3.8/multiprocessing/pool.py&quot;&lt;/span&gt;, line 48, in mapstar
    &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; list(map(*args))
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/cmdLineTask.py&quot;&lt;/span&gt;, line 433, in __call__
    result = self.runTask(task, dataRef, kwargs)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/cmdLineTask.py&quot;&lt;/span&gt;, line 504, in runTask
    &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; task.runDataRef(dataRef, **kwargs)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/drp_stella/w.2023.02/python/pfs/drp/stella/fitPfsFluxReference.py&quot;&lt;/span&gt;, line 174, in runDataRef
    reference = self.run(pfsConfig, merged, mergedLsf)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/drp_stella/w.2023.02/python/pfs/drp/stella/fitPfsFluxReference.py&quot;&lt;/span&gt;, line 275, in run
    radialVelocities = self.getRadialVelocities(pfsConfig, pfsMerged, pfsMergedLsf, bbPdfs)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/drp_stella/w.2023.02/python/pfs/drp/stella/fitPfsFluxReference.py&quot;&lt;/span&gt;, line 423, in getRadialVelocities
    radialVelocities.append(self.estimateRadialVelocity.run(spectrum, modelSpectrum))
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/drp_stella/w.2023.02/python/pfs/drp/stella/estimateRadialVelocity.py&quot;&lt;/span&gt;, line 166, in run
    pfit, pcov = scipy.optimize.curve_fit(
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-3.0.0/lib/python3.8/site-packages/scipy/optimize/_minpack_py.py&quot;&lt;/span&gt;, line 811, in curve_fit
    raise ValueError(&lt;span class=&quot;code-quote&quot;&gt;&quot;`sigma` must be positive definite.&quot;&lt;/span&gt;) from e
ValueError: `sigma` must be positive definite.
&quot;&quot;&quot;The above exception was the direct cause of the following exception:Traceback (most recent call last):
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/drp_stella/w.2023.02/bin/fitPfsFluxReference.py&quot;&lt;/span&gt;, line 3, in &amp;lt;module&amp;gt;
    FitPfsFluxReferenceTask.parseAndRun()
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/cmdLineTask.py&quot;&lt;/span&gt;, line 688, in parseAndRun
    resultList = taskRunner.run(parsedCmd)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/cmdLineTask.py&quot;&lt;/span&gt;, line 244, in run
    resultList = list(mapFunc(self, targetList))
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/cmdLineTask.py&quot;&lt;/span&gt;, line 47, in _runPool
    &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; pool.map_async(function, iterable).get(timeout)
  File &lt;span class=&quot;code-quote&quot;&gt;&quot;/work/stack_INFRA-312/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-3.0.0/lib/python3.8/multiprocessing/pool.py&quot;&lt;/span&gt;, line 771, in get
    raise self._value
ValueError: `sigma` must be positive definite.
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;Note that I specified like `--id visit=83219 spectrograph=1`.&lt;/p&gt;</description>
                <environment></environment>
        <key id="23209">PIPE2D-1147</key>
            <summary>flux calibration fails for m-band data</summary>
                <type id="3" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10518&amp;avatarType=issuetype">Task</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="sogo.mineo">sogo.mineo</assignee>
                                    <reporter username="kiyoto.yabe">Kiyoto Yabe</reporter>
                        <labels>
                    </labels>
                <created>Wed, 18 Jan 2023 01:49:14 +0000</created>
                <updated>Wed, 25 Jan 2023 06:41:30 +0000</updated>
                            <resolved>Wed, 25 Jan 2023 06:41:30 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                <comments>
                            <comment id="32100" author="kiyoto.yabe" created="Wed, 18 Jan 2023 01:51:00 +0000"  >&lt;p&gt;FWIW, there is a strange FLUXSTD which may be affected by the fiberProfile issued we discussed in the phonecon.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;a id=&quot;15497_thumb&quot; href=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15497/15497_v83219_fiberId342.png&quot; title=&quot;v83219_fiberId342.png&quot; file-preview-type=&quot;image&quot; file-preview-id=&quot;15497&quot; file-preview-title=&quot;v83219_fiberId342.png&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/thumbnail/15497/_thumb_15497.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/a&gt;&lt;/span&gt;&lt;/p&gt;</comment>
                            <comment id="32101" author="sogo.mineo" created="Wed, 18 Jan 2023 07:43:47 +0000"  >&lt;p&gt;Please try &lt;tt&gt;--config estimateRadialVelocity.useCovar=False&lt;/tt&gt;.&lt;/p&gt;

&lt;p&gt;The exception was raised by EstimateRadialVelocityTask at the final step of its work. It wanted to find in a fractional accuracy the center of the highest peak in the cross correlation function. It tried to fit a Gaussian to the peak, and failed. I guess the reason is that the peak was fatter than I assumed it to be. Such a situation makes the covariance matrix nearly singular. Using the entire covariance in fitting is extremely more fragile than using its diagonal elements only.&lt;/p&gt;

&lt;p&gt;I gave the fitter not only the diagonal errors but also the entire covariance matrix because the error estimate of the peak position (that is, the error of the radial velocity) that was output by the fitter was correct only when I gave the entire covariance matrix. Because it was planned to use the velocity error later, I had to give the entire covariance matrix. Since the velocity error is not used now, you can safely set &lt;tt&gt;--config estimateRadialVelocity.useCovar=False&lt;/tt&gt;.&lt;/p&gt;</comment>
                            <comment id="32103" author="kiyoto.yabe" created="Thu, 19 Jan 2023 02:00:21 +0000"  >&lt;p&gt;Thank you! With that config, the process was successfully completed. So, are we going to remove that option (or set False as default) in future?&lt;/p&gt;</comment>
                            <comment id="32105" author="sogo.mineo" created="Thu, 19 Jan 2023 07:26:18 +0000"  >&lt;p&gt;Yamashita-san agreed. I further asked him whether I can change the Gaussian fit to&#160;quadratic interpolation, which is more robust. He agreed to it, too. I will implement it in this ticket.&lt;/p&gt;</comment>
                            <comment id="32112" author="sogo.mineo" created="Tue, 24 Jan 2023 05:24:59 +0000"  >&lt;p&gt;Could you review this PR?&lt;/p&gt;</comment>
                            <comment id="32123" author="sogo.mineo" created="Wed, 25 Jan 2023 06:41:30 +0000"  >&lt;p&gt;Merged. Thank you for the review.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="15497" name="v83219_fiberId342.png" size="204343" author="kiyoto.yabe" created="Wed, 18 Jan 2023 01:49:41 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|zzsvzz:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>price</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>