<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:03:20 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-1143] sky subtraction is bad for a certain fraction of fibers in the faint galaxy frames taken during Nov run</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1143</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;Reducing the data for faint galaxies (visit=83244..83249) taken during the Nov run, I just noticed that the sky subtraction for some fibers is (still) significantly bad. Commands I ran are in this &lt;span class=&quot;nobr&quot;&gt;&lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15492/15492_reduction_run08_galaxies_example.sh&quot; title=&quot;reduction_run08_galaxies_example.sh attached to PIPE2D-1143&quot;&gt;reduction_run08_galaxies_example.sh&lt;sup&gt;&lt;img class=&quot;rendericon&quot; src=&quot;https://pfspipe.ipmu.jp/jira/images/icons/link_attachment_7.gif&quot; height=&quot;7&quot; width=&quot;7&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/sup&gt;&lt;/a&gt;&lt;/span&gt;. Some examples of good and bad subtraction are shown below. Those are coadded pfsObjects but I see the same things in pfsMerged and in a single visit.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15491/15491_bad_subtraction_example1.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15490/15490_good_subtraction_example1.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;</description>
                <environment></environment>
        <key id="23200">PIPE2D-1143</key>
            <summary>sky subtraction is bad for a certain fraction of fibers in the faint galaxy frames taken during Nov run</summary>
                <type id="3" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10518&amp;avatarType=issuetype">Task</type>
                                            <priority id="3" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/major.svg">Major</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="price">price</assignee>
                                    <reporter username="kiyoto.yabe">Kiyoto Yabe</reporter>
                        <labels>
                            <label>collab-datarelease</label>
                    </labels>
                <created>Fri, 13 Jan 2023 14:19:48 +0000</created>
                <updated>Fri, 17 Feb 2023 04:14:34 +0000</updated>
                            <resolved>Thu, 16 Feb 2023 16:09:54 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>5</watches>
                                                                <comments>
                            <comment id="32092" author="price" created="Fri, 13 Jan 2023 18:14:45 +0000"  >&lt;p&gt;Could you please tell me how the sky fiber positions were selected?&lt;/p&gt;</comment>
                            <comment id="32093" author="kiyoto.yabe" created="Sat, 14 Jan 2023 00:29:17 +0000"  >&lt;p&gt;Sky fibers used for the subtraction? I didn&apos;t specify them so config.selectSky.fiberFilter=&apos;ALL&apos;.&lt;/p&gt;</comment>
                            <comment id="32094" author="rhl" created="Sat, 14 Jan 2023 00:33:52 +0000"  >&lt;p&gt;I thought that this was a &quot;proper&quot; extra-Galactic field from HSC, so shouldn&apos;t we have SKY objects?  Will we have SKY objects in the next engineering runs?&lt;/p&gt;

&lt;p&gt;I don&apos;t think that this can explain the problem, though, as we are over subtracting the OH.&lt;/p&gt;</comment>
                            <comment id="32095" author="kiyoto.yabe" created="Sat, 14 Jan 2023 00:46:06 +0000"  >&lt;p&gt;Murata-san&apos;s sky object DB was used and we have 500 SKY fibers (in entire focal plane not SM1&amp;amp;3) in this field.&lt;/p&gt;</comment>
                            <comment id="32096" author="rhl" created="Sat, 14 Jan 2023 15:09:21 +0000"  >&lt;p&gt;Ah, OK.  So they were specified in the pfsDesign, which is all that matters.  &lt;/p&gt;

&lt;p&gt;You shouldn&apos;t ever need to &lt;tt&gt;config.selectSky.fiberFilter&lt;/tt&gt; except for interactive fiddling (a better solution is to write a pfsConfig to the rerun).&lt;/p&gt;</comment>
                            <comment id="32098" author="kiyoto.yabe" created="Tue, 17 Jan 2023 08:35:59 +0000"  >&lt;p&gt;FWIW, attached is the location of fibers with large residual (using an isolated sky line) and sky fibers on PFI plane. It looks that there is no strong (anti-) correlation?&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/thumbnail/15494/_thumb_15494.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;</comment>
                            <comment id="32108" author="price" created="Sat, 21 Jan 2023 00:14:13 +0000"  >&lt;p&gt;This is due to fibers being in the penumbra of nearby black spots. Based on a bunch of sky lines from two exposures (83149 and 83244), the throughput appears to be linear with distance from the black spot (slope of 1.232/mm) up to a distance of 1.108 mm.&lt;br/&gt;
I&apos;ve added a correction for this effect in &lt;tt&gt;reduceExposure&lt;/tt&gt;. The correction modifies the normalisation, so that the flux is still what is extracted from the image.&lt;br/&gt;
In order to keep track of the correction (and other reduction operations and quality measurements), I&apos;ve added a new element to the spectra, currently called &quot;notes&quot;. This is an addition to the datamodel, so needs approval via a DAMD ticket.&lt;br/&gt;
Using the fixed code, I get the following sky-subtracted merged spectrum for &lt;tt&gt;visit=83244 fiberId=478&lt;/tt&gt; (which observes &lt;tt&gt;objId=43158588759244917&lt;/tt&gt;, which had the bad sky subtraction):&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15501/15501_Xnip2023-01-20_17-15-59.jpg&quot; width=&quot;1000&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;</comment>
                            <comment id="32196" author="price" created="Sat, 4 Feb 2023 01:47:16 +0000"  >&lt;p&gt;This includes the changes of &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/browse/DAMD-145&quot; title=&quot;Add facility to hold history/metrics of spectra&quot; class=&quot;issue-link&quot; data-issue-key=&quot;DAMD-145&quot;&gt;&lt;del&gt;DAMD-145&lt;/del&gt;&lt;/a&gt; (adding reduction notes to spectral products) in order to record the values that were used.&lt;/p&gt;</comment>
                            <comment id="32219" author="hassan" created="Fri, 10 Feb 2023 18:25:12 +0000"  >&lt;p&gt;Changes approved. Could not see any obvious issues with the proposed changes, including the new &lt;tt&gt;notes&lt;/tt&gt; mechanism. Perhaps a slope to model the penumbra may be too simplistic for the future, but it works now and is a good start.&lt;/p&gt;</comment>
                            <comment id="32223" author="price" created="Sat, 11 Feb 2023 17:22:58 +0000"  >&lt;p&gt;Need to check: it looks like I might be making the correction twice (once in extractSpectra, and once in reduceExposure).&lt;/p&gt;</comment>
                            <comment id="32233" author="price" created="Mon, 13 Feb 2023 16:16:35 +0000"  >&lt;p&gt;I double-checked, and I am &lt;b&gt;not&lt;/b&gt; making the correction twice. The second correction is in &lt;tt&gt;pfs.drp.stella.pipelines.extractSpectra&lt;/tt&gt; (part of the Gen3 pipeline that replaces &lt;tt&gt;reduceExposure&lt;/tt&gt;), not &lt;tt&gt;pfs.drp.stella.extractSpectra&lt;/tt&gt; (the building block).&lt;/p&gt;</comment>
                            <comment id="32250" author="price" created="Thu, 16 Feb 2023 16:09:54 +0000"  >&lt;p&gt;Merged to master.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10000">
                    <name>Blocks</name>
                                            <outwardlinks description="blocks">
                                        <issuelink>
            <issuekey id="23195">PIPE2D-1140</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="is blocked by">
                                        <issuelink>
            <issuekey id="23217">DAMD-145</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="23255">PIPE2D-1165</issuekey>
        </issuelink>
                            </outwardlinks>
                                                                <inwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="23195">PIPE2D-1140</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="15491" name="bad_subtraction_example1.png" size="161780" author="kiyoto.yabe" created="Fri, 13 Jan 2023 14:16:24 +0000"/>
                            <attachment id="15494" name="fibers_with_large_residual_on_pfi.png" size="43208" author="kiyoto.yabe" created="Tue, 17 Jan 2023 08:28:31 +0000"/>
                            <attachment id="15490" name="good_subtraction_example1.png" size="205134" author="kiyoto.yabe" created="Fri, 13 Jan 2023 14:16:48 +0000"/>
                            <attachment id="15502" name="image (7).png" size="240940" author="price" created="Sat, 21 Jan 2023 00:01:41 +0000"/>
                            <attachment id="15492" name="reduction_run08_galaxies_example.sh" size="2128" author="kiyoto.yabe" created="Fri, 13 Jan 2023 14:16:06 +0000"/>
                            <attachment id="15501" name="Xnip2023-01-20_17-15-59.jpg" size="257074" author="price" created="Sat, 21 Jan 2023 00:00:51 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qph7:07fi</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>hassan</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10005" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="162">2DDRP-2023 A</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>