<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:03:15 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-1137] add flags in LineList</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1137</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;I would like to have 2 flags in the LineList to identify the lines used by LAM to make detector focus adjustment and one for the image quality measurement.&lt;/p&gt;

&lt;p&gt;if it is ok, how it works? how do we proceed?&lt;/p&gt;</description>
                <environment></environment>
        <key id="23187">PIPE2D-1137</key>
            <summary>add flags in LineList</summary>
                <type id="3" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10518&amp;avatarType=issuetype">Task</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="hassan">hassan</assignee>
                                    <reporter username="fmadec">fmadec</reporter>
                        <labels>
                            <label>SPS</label>
                    </labels>
                <created>Wed, 4 Jan 2023 16:56:11 +0000</created>
                <updated>Fri, 5 May 2023 16:43:50 +0000</updated>
                            <resolved>Fri, 5 May 2023 16:43:50 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                <comments>
                            <comment id="32055" author="price" created="Wed, 4 Jan 2023 17:12:44 +0000"  >&lt;p&gt;How do you use DRP2D outputs for focus adjustment and image quality measurement?&lt;/p&gt;</comment>
                            <comment id="32056" author="hassan" created="Wed, 4 Jan 2023 17:34:02 +0000"  >&lt;p&gt;I&apos;ve added to the ticket branch the following flags:&lt;/p&gt;

&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
LAM_FOCUS = 0x800, &lt;span class=&quot;code-quote&quot;&gt;&quot;Line is used by LAM &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; detector focus purposes&quot;&lt;/span&gt;
LAM_IMAGEQUALITY = 0x1000, &lt;span class=&quot;code-quote&quot;&gt;&quot;Line is used by LAM &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; image quality measurement&quot;&lt;/span&gt;
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;Fabrice: To use those, edit the appropriate linelist file in the &lt;tt&gt;obs_pfs&lt;/tt&gt; package. For the line that needs to be updated, &lt;del&gt;logically&lt;/del&gt; bitwise-OR one of the above hex values with the existing value in the &lt;tt&gt;status&lt;/tt&gt; field for that line.&lt;/p&gt;</comment>
                            <comment id="32057" author="price" created="Wed, 4 Jan 2023 18:32:32 +0000"  >&lt;p&gt;Bitwise-OR, not logical-OR.&lt;/p&gt;</comment>
                            <comment id="32058" author="hassan" created="Wed, 4 Jan 2023 19:47:08 +0000"  >&lt;p&gt;Bitwise-OR of course. Comment updated.&lt;/p&gt;</comment>
                            <comment id="32060" author="fmadec" created="Wed, 4 Jan 2023 21:00:46 +0000"  >&lt;p&gt;thanks!&lt;/p&gt;

&lt;p&gt;one question, can I combine them ? I mean mark one line with both flags?&lt;/p&gt;</comment>
                            <comment id="32061" author="hassan" created="Wed, 4 Jan 2023 21:02:48 +0000"  >&lt;p&gt;Yes. Just bitwise-OR all flags to the status value.&lt;/p&gt;</comment>
                            <comment id="32062" author="fmadec" created="Thu, 5 Jan 2023 10:26:10 +0000"  >&lt;p&gt;back to your question Paul: How do you use DRP2D outputs for focus adjustment and image quality measurement? &lt;/p&gt;

&lt;p&gt;right now I simply used detrend images and I have a separate list of peaks that I used (and tweak on purpose). But the lines are identified and I like to store them here.&#160;&lt;br/&gt;
during the alignment it is a bit tricky, focus is not necessary good and lines position moves.&lt;/p&gt;

&lt;p&gt;for the image quality I could use reduceArc or smthg else for DRPED to have position of lines, but I already have all code running without... will see&lt;/p&gt;

&lt;p&gt;&#160;&lt;/p&gt;</comment>
                            <comment id="32651" author="price" created="Fri, 5 May 2023 16:43:50 +0000"  >&lt;p&gt;Integration test passed. Merged to master.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qph7:0i</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>