https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1136 DRP 2-D Pipeline <p>There is a bright defect in the r3 camera which doesn't subtract out well with the dark frame processing, presumably because its amplitude varies with time.</p> <p>Please change the code to estimate the amplitude of the defect based on the part of the CCD where there are no fibre traces.</p> <p>Note that this cannot, in theory, simply be done by adjusting the amplitude of the dark frame as there may well be a stable and unstable component. An interesting experiment would be to carry out a PCA decomposition of the darks and measure the dimensionality of the needed solution.</p> PIPE2D-1136

Correctly subtract the dark signal seen on r3

Story Normal Done Done rhl rhl Wed, 21 Dec 2022 21:28:34 +0000 Wed, 22 Feb 2023 00:56:45 +0000 Thu, 5 Jan 2023 15:16:44 +0000 0 2 <p>An example is 83149</p> <p>Attached <tt>calexp</tt> images (with and without corrections for the dark current) of <tt>r3</tt> and <tt>m3</tt> visits showing the abnormality.</p> <p><a href="https://github.com/Subaru-PFS/obs_pfs/pull/142" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/obs_pfs/pull/142</a></p> <p>See <a href="https://sumire-pfs.slack.com/archives/C3AU3VCMU/p1672247056447469" class="external-link" rel="nofollow">https://sumire-pfs.slack.com/archives/C3AU3VCMU/p1672247056447469</a> for illustrations of successful testing of this code.</p> <p>N.b. The code assumes that there are no bad pixels in the dark. This needs to be fixed (maybe in a different ticket); although we don't want saturated pixels in the darks they may happen and then both the dark generation and the code that uses the darks need to be modified.</p> <p>As discussed on slack, we won't worry about versioning the BBoxes just yet.</p> <p>Also added code to handle masked pixels in darks and data, contrary to remarks made in my previous comment.</p> Relates PIPE2D-1169 Development Rank 0|02qpjd:00r20060i20018 Reviewers price