<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:03:10 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-1129] Convert detectorMap distortion model to fit for scale</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1129</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;The &lt;tt&gt;DoubleDetectorMap&lt;/tt&gt; currently models the x and y distortion separately. By modeling the distortion with dx, dy, scale and separate higher-order terms, we can link the two distortions, meaning that changes to the trace positions provide direct information to the change in the wavelength solution.&lt;/p&gt;</description>
                <environment></environment>
        <key id="23170">PIPE2D-1129</key>
            <summary>Convert detectorMap distortion model to fit for scale</summary>
                <type id="10001" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10515&amp;avatarType=issuetype">Story</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="price">price</assignee>
                                    <reporter username="price">price</reporter>
                        <labels>
                    </labels>
                <created>Mon, 12 Dec 2022 19:08:38 +0000</created>
                <updated>Thu, 21 Sep 2023 14:49:45 +0000</updated>
                            <resolved>Thu, 21 Sep 2023 14:49:45 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                <comments>
                            <comment id="32074" author="price" created="Tue, 10 Jan 2023 21:47:53 +0000"  >&lt;p&gt;Added &lt;tt&gt;MultipleDistortionsDetectorMap&lt;/tt&gt;, which allows layering multiple distortions, and added the ability to &lt;tt&gt;DoubleDistortion&lt;/tt&gt; to fit for common scale (in x and y, for both CCDs).&lt;/p&gt;</comment>
                            <comment id="32075" author="price" created="Wed, 11 Jan 2023 03:32:21 +0000"  >&lt;p&gt;Here&apos;s a plot of the atmospheric B band for a SuNSS imaging fiber close to the moon (visit=72045 fiberId=197), from an exposure with all fibers dominated by continuum and very few good strong sky lines. Before (red line), the spectrum is shifted relative to an example atmospheric transmission model (this one is zd=60, pwv=1, smoothed with sigma=2, and shifted; the zd and pwv are not appropriate for this data, but it provides a wavelength reference). The wavelength calibration after this ticket is much better.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15487/15487_pipe2d-1129.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;</comment>
                            <comment id="32202" author="price" created="Tue, 7 Feb 2023 21:17:20 +0000"  >&lt;p&gt;I&apos;ve revised the distortion fitting a bit, and am now using a model with translation, rotation and scale in x and y for the left and right CCDs. I found that using separate scale changes for the x and y axes gives a much better fit than using a common scale change. I&apos;m guessing that these are due to small tilts of the CCDs, which slightly change the distance to focus (and therefore the plate scale) linearly across the CCD.&lt;br/&gt;
Here&apos;s an example:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
With single scale:
reduceExposure.adjustDetectorMap INFO: Final result: chi2=877669.365862 dof=1014415 xRMS=0.030667 yRMS=0.184465 xSoften=0.026625 ySoften=0.000000 from 1010950 lines
reduceExposure.adjustDetectorMap INFO: Stats &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; OH: chi2=32617.887679 dof=6954 xRMS=0.068013 yRMS=0.184465 xSoften=0.000000 ySoften=0.129661 from 3477 lines

With separate x and y scales:

reduceExposure.adjustDetectorMap INFO: Final result: chi2=840824.684295 dof=1014325 xRMS=0.030314 yRMS=0.116222 xSoften=0.026204 ySoften=0.000000 from 1010932 lines
reduceExposure.adjustDetectorMap INFO: Stats &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; OH: chi2=15031.568652 dof=6814 xRMS=0.067002 yRMS=0.116222 xSoften=0.000000 ySoften=0.059637 from 3407 lines
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;What this means is that we need to have wavelength references in the exposure in order to get good wavelength solutions.&lt;/p&gt;</comment>
                            <comment id="35153" author="price" created="Wed, 20 Sep 2023 18:38:13 +0000"  >&lt;p&gt;Preparing to merge, and here&apos;s a high-level summary of the changes:&lt;/p&gt;

&lt;ul&gt;
	&lt;li&gt;Added reduceExposure output &quot;subtracted&quot;, which is an extraction-subtracted image.&lt;/li&gt;
	&lt;li&gt;Added MultipleDistortionsDetectorMap, which layers distortions on top of the model detectorMap.&lt;br/&gt;
    + I expect this to eventually replace all other types of distorted detectorMaps, since it&apos;s capable of doing what they do and more.&lt;br/&gt;
    + Allows us to support empirical pixel-based distortions (e.g., tree rings) in the future.&lt;/li&gt;
	&lt;li&gt;Added support for using trace x positions to constrain distortions in y.&lt;br/&gt;
    + Distortion in y is observed as a addition distortion in x of a trace because the traces are sloped.&lt;/li&gt;
	&lt;li&gt;Added RotScaleDistortion and DoubleRotScaleDistortion to fit a translation, rotation and common scale in x and y.&lt;/li&gt;
	&lt;li&gt;Parallelised the fitting in reduceArc.&lt;/li&gt;
	&lt;li&gt;Various optimisations.&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="35164" author="price" created="Thu, 21 Sep 2023 14:49:45 +0000"  >&lt;p&gt;Merged to master.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="15487" name="pipe2d-1129.png" size="285295" author="price" created="Wed, 11 Jan 2023 03:32:13 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qph7:07fr</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>hassan</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10005" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="162">2DDRP-2023 A</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>