https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1128 DRP 2-D Pipeline <p>The weekly of 2022-12-11 failed while looking at the wavelength residuals:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> ====================================================================== FAIL: testResiduals (__main__.ArcTestCase_brn_39) (visit=39, arm=<span class="code-quote">'r'</span>, fiberId=2) Test that wavelength fit residuals are reasonable ---------------------------------------------------------------------- Traceback (most recent call last): File <span class="code-quote">"/scratch/pprice/jenkins/weekly/2022-12-11/build/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pfs_pipe2d/w.2022.50/python/pfs/pipe2d/weekly/test_weekly.py"</span>, line 138, in testResiduals self.assertFloatsAlmostEqual(median, 0.0, atol=atol) File <span class="code-quote">"/scratch/pprice/jenkins/weekly/2022-12-11/build/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/utils/g62e1f4f43a+9633a190c8/python/lsst/utils/tests.py"</span>, line 715, in assertFloatsAlmostEqual testCase.assertFalse(failed, msg=<span class="code-quote">"\n"</span>.join(errMsg)) AssertionError: True is not <span class="code-keyword">false</span> : 0.04064752062453181 != 0.0; diff=0.04064752062453181/0.04064752062453181=1.0 with rtol=2.220446049250313e-16, atol=0.02 </pre> </div></div> <p>This is likely related to <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1122" title="Investigate poor detectorMap adjustment in r1" class="issue-link" data-issue-key="PIPE2D-1122"><del>PIPE2D-1122</del></a>.</p> PIPE2D-1128

Fix weekly breakage 2022-12-11

Story Normal Done Done price price Mon, 12 Dec 2022 18:25:41 +0000 Fri, 16 Dec 2022 15:33:06 +0000 Fri, 16 Dec 2022 15:33:06 +0000 0 2 <p>This was due to including <tt>Trace</tt> pseudo-lines in the the wavelength residual measurements. They don't have real wavelengths, so it doesn't make sense to include them.</p> <p>The <tt>Trace</tt> lines weren't being output previously, so this is a sign of improvements!</p> <p>Suggested changes in pull request are fine, thanks.</p> <p>Merged.</p> Development Rank 0|zzsvt3: Reviewers hassan