https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1127 DRP 2-D Pipeline <p><tt>fitPfsReferenceFlux.py</tt> currently uses <tt>pfsConfig.fiberFlux</tt> but it has to be <tt>pfsConfig.psfFlux</tt> because <tt>pfsConfig</tt> files that came out of observation contain <tt>psfFlux</tt> only.</p> <p>Because there are disagreements as to which flux to use, we should make it configurable.</p> PIPE2D-1127

Type of broadband fluxes used by flux calibration should be configurable

Task Normal Done Done sogo.mineo sogo.mineo flux-calibration Mon, 12 Dec 2022 05:41:23 +0000 Wed, 14 Dec 2022 05:06:44 +0000 Wed, 14 Dec 2022 05:06:44 +0000 0 2 <p>Surely fiberFlux and psfFlux should be very close to identical for the stars we want to use to calibrate against, and if they're not then it's not a suitable calibration source? The two should differ only for extended sources.</p> <p>They are close, but in reality pfsConfig.fiberFlux is NaN while pfsConfig.psfFlux is finite. The current code needs amending because it uses fiberFlux only. To hard-code psfFlux will suffice, but it is also easy to add a configuration parameter to choose between fiberFlux and psfFlux.</p> <p>Could you review this PR? I made two commits: the first one is the essential one. In the second commit, I typed several python scripts.</p> <p>Merged. (I don't think it a necessary condition for merging that mypy runs cleanly...) Thank you for the review.</p> Development Rank 0|zzsvsv: Reviewers price