<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:02:38 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-1094] Organise H4RG defects by logical serial number (snX) not spectrograph number (nY)</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1094</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;The mapping of H4RG device to final spectrograph is not yet known, and indeed the mapping is different at JHU and LAM. &#160;Accordingly, we added &lt;tt&gt;sn&lt;/tt&gt; names for the chips as follows:&lt;/p&gt;
&lt;div class=&apos;table-wrap&apos;&gt;
&lt;table class=&apos;confluenceTable&apos;&gt;&lt;tbody&gt;
&lt;tr&gt;
&lt;th class=&apos;confluenceTh&apos;&gt;sn&lt;/th&gt;
&lt;th class=&apos;confluenceTh&apos;&gt;serial&lt;/th&gt;
&lt;th class=&apos;confluenceTh&apos;&gt;arm at JHU&lt;/th&gt;
&lt;th class=&apos;confluenceTh&apos;&gt;arm at LAM&lt;/th&gt;
&lt;th class=&apos;confluenceTh&apos;&gt;arm at MKO&lt;/th&gt;
&lt;/tr&gt;
&lt;tr&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;sn1&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;18315&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;n3&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;n2&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;&#160;&lt;/td&gt;
&lt;/tr&gt;
&lt;tr&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;sn2&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;18660&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;n2&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;&#160;&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;&#160;&lt;/td&gt;
&lt;/tr&gt;
&lt;tr&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;sn3&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;18321&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;&#160;&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;&#160;&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;&#160;&lt;/td&gt;
&lt;/tr&gt;
&lt;tr&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;sn4&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;18661&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;&#160;&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;&#160;&lt;/td&gt;
&lt;td class=&apos;confluenceTd&apos;&gt;&#160;&lt;/td&gt;
&lt;/tr&gt;
&lt;/tbody&gt;&lt;/table&gt;
&lt;/div&gt;


&lt;p&gt;The defects need to be arranged by &lt;tt&gt;sn&lt;/tt&gt; number, not spectrograph number. &#160;In order for this to be useful, the script that ingests them to be used in a calibration directory needs to be a little smarter:&lt;/p&gt;
&lt;ul&gt;
	&lt;li&gt;copy &lt;tt&gt;$DRP_PFS_DATA_DIR/curated/pfs/defects/snX&lt;/tt&gt; to &lt;tt&gt;StagingDirectory/nY&lt;/tt&gt; with the mapping depending on the site&lt;/li&gt;
	&lt;li&gt;patch the header in the defects &lt;tt&gt;.ecsv&lt;/tt&gt;&#160;files to map to the correct detector&lt;/li&gt;
	&lt;li&gt;Run &lt;tt&gt;ingestCuratedCalibs.py $TARGET --calib $TARGET/CALIB StagingDirectory --config clobber=True&lt;/tt&gt;&lt;/li&gt;
&lt;/ul&gt;


&lt;p&gt;While working on this ticket, we should add the serial to the metadata in the defects &lt;tt&gt;.ecsv&lt;/tt&gt; files&lt;/p&gt;</description>
                <environment></environment>
        <key id="23060">PIPE2D-1094</key>
            <summary>Organise H4RG defects by logical serial number (snX) not spectrograph number (nY)</summary>
                <type id="10001" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10515&amp;avatarType=issuetype">Story</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="rhl">rhl</assignee>
                                    <reporter username="rhl">rhl</reporter>
                        <labels>
                            <label>NIR</label>
                    </labels>
                <created>Sun, 16 Oct 2022 19:48:39 +0000</created>
                <updated>Wed, 2 Nov 2022 18:14:20 +0000</updated>
                            <resolved>Mon, 17 Oct 2022 19:58:00 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                <comments>
                            <comment id="31628" author="rhl" created="Mon, 17 Oct 2022 03:34:39 +0000"  >&lt;p&gt;Not all that beautiful, but it seems to work. &#160;The critical script is in obs_pfs and has a reasonably extensive description. &#160;Basically, you need to setup the proper version of drp_pfs_data (i.e. one on this branch) and run a command like&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
TARGET=/projects/HSC/PFS/LAM
#rm -f $TARGET/CALIB/calibRegistry.sqlite3 
ingestPfsDefects --lam ~/sss/stagingArea $TARGET --calib $TARGET/CALIB --config clobber=True
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;You can specify the location of the defects on the command line instead if you prefer.&lt;/p&gt;

&lt;p&gt;See&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://github.com/Subaru-PFS/drp_pfs_data/pull/21&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://github.com/Subaru-PFS/drp_pfs_data/pull/21&lt;/a&gt;&lt;/p&gt;

&lt;p&gt;&lt;a href=&quot;https://github.com/Subaru-PFS/obs_pfs/pull/130&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://github.com/Subaru-PFS/obs_pfs/pull/130&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="31631" author="rhl" created="Mon, 17 Oct 2022 19:58:00 +0000"  >&lt;p&gt;Merged&lt;/p&gt;</comment>
                            <comment id="31694" author="hassan" created="Fri, 28 Oct 2022 18:16:56 +0000"  >&lt;p&gt;As Paul points out, the &lt;tt&gt;drp_pfs_data&lt;/tt&gt; ticket branch has not been merged.&lt;/p&gt;</comment>
                            <comment id="31697" author="hassan" created="Sun, 30 Oct 2022 17:55:01 +0000"  >&lt;p&gt;Merged &lt;tt&gt;drp_pfs_data&lt;/tt&gt; changes to master.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="23094">PIPE2D-1107</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                            <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|zzsv6v:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>cloomis</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>