https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1082 DRP 2-D Pipeline <p>The changelog (e.g., <a href="http://tigress-web.princeton.edu/~HSC/pfs-drp-2d/changelog/commissioning-2022919.html" class="external-link" rel="nofollow">here</a>) is including lots of recent work under "not tagged", apparently because it doesn't recognise weekly tags. Since we now distribute weeklies and rarely use Proper X.Y.Z releases, this makes the changelog much less useful.</p> PIPE2D-1082

Changelog should recognise weekly tags

Story Normal Done Done hassan price Tue, 20 Sep 2022 20:52:15 +0000 Thu, 13 Oct 2022 14:55:40 +0000 Sun, 2 Oct 2022 01:47:58 +0000 0 2 <p>This is essentially a re-write of the changelog code, including:</p> <ol> <li>Replacing ad-hoc code to access the Github REST API with the <tt>pyGithub</tt> library</li> <li>Searching pull requests has been dropped, as not all tickets have been closed against pull requests.</li> <li>Implementing an alternative algorithm to determine tickets closed for a given tag. The new algorithm now searches up the master branch for ticket branch merges</li> <li>Weekly tags are now the only tags used.</li> <li>As weekly tags are used, the tag issue prior to <tt>w.2020.20</tt> where only <tt>pfs_pipe2d</tt> was tagged (as part of a release), the rather flaky mechanism of determining tickets-to-tag assignment based on datestamps is removed.</li> </ol> <p>I think we need to consider tags in addition to the weeklies, as every now and then we use them (e.g., I made two mid-week tags for the commissioning run).</p> <p>We discussed timing, as the first run (on only two repos) took a few minutes, but then subsequent runs were faster (just over a minute). Profiling the subsequent runs shows the time is dominated by communication. The Jira data is cached next to the code, but I think putting it in <tt>~/.pfs/</tt> would make it more useful. We could probably greatly speed up the code by caching the GitHub data, but we only run this code once a week, with an automated system, at a time when the machine is quiet, so I don't think that's a high priority, and maybe not even worth worrying about.</p> <p>Since this is a re-write, this might be a good opportunity to get a feel for including python typing, and running the code through <tt>black</tt> and <tt>isort</tt>.</p> <p>Merged to master. Will address support for tag types other than weeklies in a separate, future ticket.</p> Duplicate PIPE2D-834 Relates PIPE2D-1087 Development Rank 0|02qpjd:00r2006 Reviewers price