<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:02:18 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-1066] Handle inter-fiber optical crosstalk.</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1066</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;The dot-roaching runs in 2022-06 showed that there is significant crosstalk between fibers, and gave preliminary coefficients (rhl has these).  This needs to be accounted for in normal DRP processing.&lt;/p&gt;</description>
                <environment></environment>
        <key id="22904">PIPE2D-1066</key>
            <summary>Handle inter-fiber optical crosstalk.</summary>
                <type id="3" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10518&amp;avatarType=issuetype">Task</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="price">price</assignee>
                                    <reporter username="cloomis">cloomis</reporter>
                        <labels>
                            <label>EngRun</label>
                    </labels>
                <created>Fri, 5 Aug 2022 14:07:41 +0000</created>
                <updated>Thu, 20 Oct 2022 18:58:08 +0000</updated>
                            <resolved>Mon, 19 Sep 2022 22:47:23 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>4</watches>
                                                                <comments>
                            <comment id="31211" author="rhl" created="Fri, 5 Aug 2022 18:34:35 +0000"  >&lt;p&gt;Actually, I measured the coefficients from a bright star &amp;#8211; much more dynamic range.  My notes say&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
np.array([1.00000000e+00, 4.41695363e-03, 1.26907573e-03, 6.37238677e-04, 3.99808286e-04])
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                            <comment id="31228" author="rhl" created="Tue, 16 Aug 2022 16:42:45 +0000"  >&lt;p&gt;After some discussion, we decided that this should be done in 2-D. &#160;One way would be to add these terms to the fibre profiles; another would be to &lt;em&gt;not&lt;/em&gt; include them in the fibre profiles but to run a per-row correction just before writing the pfsArm files.&lt;/p&gt;

&lt;p&gt;In fact, of course, the cross-talk is 2-D, but we are planning to handle that by PFS subtraction in 2-D, including the far wings of the PSF, for lines that are bright enough to be a problem. &#160; We do, naturally, have to be careful that we correct once and only once.&lt;/p&gt;</comment>
                            <comment id="31269" author="price" created="Wed, 31 Aug 2022 21:49:49 +0000"  >&lt;p&gt;Exactly what do the above coefficients represent, and how were they measured?&lt;/p&gt;</comment>
                            <comment id="31389" author="price" created="Fri, 16 Sep 2022 20:23:27 +0000"  >&lt;p&gt;I&apos;ve an implementation that appears to work. I&apos;d love to check it out on the original data used to measure the coefficients. &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl&quot; class=&quot;user-hover&quot; rel=&quot;rhl&quot;&gt;rhl&lt;/a&gt;, do you have the visit number handy?&lt;/p&gt;</comment>
                            <comment id="31394" author="rhl" created="Sat, 17 Sep 2022 01:24:29 +0000"  >&lt;p&gt;Sorry, I should have included that information. &#160;&lt;tt&gt;visit, arm = 78454, &apos;r&apos;&lt;/tt&gt;;&#160;&lt;tt&gt;fiberId = 586&lt;/tt&gt;&lt;/p&gt;</comment>
                            <comment id="31408" author="hassan" created="Sun, 18 Sep 2022 22:46:17 +0000"  >&lt;p&gt;Changes in code look fine with me. Minor comment on parameter doc. See pull request &lt;a href=&quot;https://github.com/Subaru-PFS/drp_stella/pull/286&quot; class=&quot;external-link&quot; rel=&quot;nofollow&quot;&gt;https://github.com/Subaru-PFS/drp_stella/pull/286&lt;/a&gt;.&lt;/p&gt;</comment>
                            <comment id="31409" author="price" created="Mon, 19 Sep 2022 19:03:47 +0000"  >&lt;p&gt;The below plots show the spectra around &lt;tt&gt;fiberId=586&lt;/tt&gt; before (dotted lines) and after (solid lines) the optical crosstalk correction. The first shows the full dynamic range. Note that the flux in the bright fiber is barely affected by the correction. The second shows a zoom around zero flux, where it can be seen the flux before correction is non-zero (especially for the two fibers closest to the bright one, blue and cyan), and that after correction it is much closer to zero.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15330/15330_pipe2d-1066-bright.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;br/&gt;
&lt;span class=&quot;image-wrap&quot; style=&quot;&quot;&gt;&lt;img src=&quot;https://pfspipe.ipmu.jp/jira/secure/attachment/15331/15331_pipe2d-1066-zoom.png&quot; style=&quot;border: 0px solid black&quot; /&gt;&lt;/span&gt;&lt;/p&gt;</comment>
                            <comment id="31410" author="rhl" created="Mon, 19 Sep 2022 19:33:32 +0000"  >&lt;p&gt;The &quot;bright&quot; fibre shouldn&apos;t be affected at all, should it, if there&apos;s no real flux in the neighbouring fibres? &#160;How much is it modified?&lt;/p&gt;</comment>
                            <comment id="31411" author="price" created="Mon, 19 Sep 2022 20:39:26 +0000"  >&lt;p&gt;The bright fiber is barely modified (the difference is 0.05 +/- 0.11 counts).&lt;/p&gt;

&lt;p&gt;Merged to master.&lt;/p&gt;</comment>
                            <comment id="31412" author="rhl" created="Mon, 19 Sep 2022 20:46:28 +0000"  >&lt;p&gt;OK, now that &quot;barely&quot; means &quot;not significantly&quot; I&apos;m happy. &#160;I took it to mean a small but real shift (as e.g. you&apos;d see if we did a na&#239;ve &quot;1-loop&quot; correction not a full matrix inversion.&lt;/p&gt;</comment>
                            <comment id="31413" author="price" created="Mon, 19 Sep 2022 22:53:52 +0000"  >&lt;p&gt;Oh, I should note a couple of things:&lt;/p&gt;

&lt;p&gt;1. The crosstalk correction needs to be activated explicitly (&lt;tt&gt;extractSpectra.doCrosstalk=True&lt;/tt&gt;).&lt;br/&gt;
2. The overwhelming lack of reference points on &lt;tt&gt;visit=78454&lt;/tt&gt; (which contains three traces and no emission lines) makes me wonder if the detectorMap adjustment in the spectral extraction used to measure the original crosstalk coefficients was reasonable. I have added a &lt;tt&gt;doForceTraces&lt;/tt&gt; parameter to &lt;tt&gt;reduceExposure.py&lt;/tt&gt; that forces use of traces (not just emission lines) when doing the detectorMap adjustment; this also needs to be activated explicitly.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="22957">PIPE2D-1080</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="22965">PIPE2D-1084</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="23070">PIPE2D-1099</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="23072">PIPE2D-1100</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                            <attachment id="15330" name="pipe2d-1066-bright.png" size="38145" author="price" created="Mon, 19 Sep 2022 18:59:08 +0000"/>
                            <attachment id="15331" name="pipe2d-1066-zoom.png" size="210295" author="price" created="Mon, 19 Sep 2022 18:59:09 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qpio:k</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>hassan</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10005" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="152">preEngRun07Sep</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10002" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Story Points</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>4.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                        </customfields>
    </item>
</channel>
</rss>