https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1056 DRP 2-D Pipeline <p>When PfsMerged with 32bit mask is input to fitPfsFluxReference.py, the following exception is raised, because 64bit integer cannot be shortened to the 32bit mask.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> Traceback (most recent call last): File <span class="code-quote">"/lsst_stack/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-3.0.0/lib/python3.8/multiprocessing/pool.py"</span>, line 125, in worker result = (True, func(*args, **kwds)) File <span class="code-quote">"/lsst_stack/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe-3.0.0/lib/python3.8/multiprocessing/pool.py"</span>, line 48, in mapstar <span class="code-keyword">return</span> list(map(*args)) File <span class="code-quote">"/lsst_stack/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/cmdLineTask.py"</span>, line 433, in __call__ result = self.runTask(task, dataRef, kwargs) File <span class="code-quote">"/lsst_stack/stack/miniconda3-py38_4.9.2-3.0.0/Linux64/pipe_base/g590c34a36e+5da9528084/python/lsst/pipe/base/cmdLineTask.py"</span>, line 504, in runTask <span class="code-keyword">return</span> task.runDataRef(dataRef, **kwargs) File <span class="code-quote">"/pfs_pipeline/drp_stella/python/pfs/drp/stella/fitPfsFluxReference.py"</span>, line 146, in runDataRef reference = self.run(pfsConfig, merged, mergedLsf) File <span class="code-quote">"/pfs_pipeline/drp_stella/python/pfs/drp/stella/fitPfsFluxReference.py"</span>, line 247, in run likelihoods = self.fitModelsToSpectra( File <span class="code-quote">"/pfs_pipeline/drp_stella/python/pfs/drp/stella/fitPfsFluxReference.py"</span>, line 465, in fitModelsToSpectra obsSpectra = self.maskUninterestingRegions(obsSpectra) File <span class="code-quote">"/pfs_pipeline/drp_stella/python/pfs/drp/stella/fitPfsFluxReference.py"</span>, line 735, in maskUninterestingRegions spectra.mask[...] |= np.where( TypeError: ufunc <span class="code-quote">'bitwise_or'</span> output (typecode <span class="code-quote">'l'</span>) could not be coerced to provided output parameter (typecode <span class="code-quote">'I'</span>) according to the casting rule <span class="code-quote">''same_kind'</span>' </pre> </div></div> PIPE2D-1056

fitPfsFluxReference.py: type mismatch caused by 32bit mask

Task Normal Done Done sogo.mineo sogo.mineo flux-calibration Fri, 1 Jul 2022 05:22:03 +0000 Thu, 7 Jul 2022 06:12:40 +0000 Mon, 4 Jul 2022 00:52:11 +0000 0 3 <p>Could you review this PR?</p> <p>Changes look fine, but I'm concerned that we're using 64-bit masks somewhere. Everything should be 32-bit, I thought.</p> <p>One of the origins of 64bit integers is <tt>ii</tt> at pfs/datamodel/masks.py line 61. Because <tt>ii</tt> is python's integer, <tt>value</tt> at line 63 is python's integer. <tt>self.flags<span class="error">&#91;name&#93;</span></tt> at line 67 and <tt>2**self.flags<span class="error">&#91;name&#93;</span></tt> at line 35 are also python's integer. Therefore MaskHelper.add() returns python's integer. Because I had written "<tt>np.where(condition, 0, spectra.flags.add("EDGE"))</tt>," the array returned by this <tt>np.where</tt> had been of <tt>np.int64</tt> type. This is why I changed <tt>np,where(...)</tt> to <tt>np,where(...).astype(lhs.dtype)</tt></p> <p>Merged to master. Thanks for your review.</p> Development Epic Link PIPE2D-303 Rank 0|02qpjd:00xznup2cri Reviewers price