PFS-JIRA https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 [PIPE2D-1028] Wavelengths in bandpass files in obs_pfs should be in vacuum https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1028 DRP 2-D Pipeline <p>Bandpass data were added to <tt>obs_pfs</tt> in <tt>tickets/<a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-922" title="Write a main code to run the blue part in flux calibration with some dummy functions" class="issue-link" data-issue-key="PIPE2D-922"><del>PIPE2D-922</del></a></tt>, but the wavelength values in these files were in-air values. They should be converted to in-vacuum values.</p> PIPE2D-1028 Wavelengths in bandpass files in obs_pfs should be in vacuum Task Normal Done Done sogo.mineo sogo.mineo Tue, 26 Apr 2022 07:00:03 +0000 Mon, 6 Jun 2022 02:51:31 +0000 Wed, 11 May 2022 05:23:18 +0000 0 2 <p>I have decided to use Peck &amp; Reeder (1972):</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> def vacuum_to_air(wavelength_in_vacuum): ss = (1e3 / wavelength_in_vacuum)**2 n = 1.0000806051 + 0.02480990 / (132.274 - ss) + 0.000174557 / (39.32957 - ss) <span class="code-keyword">return</span> wavelength_in_vacuum / n </pre> </div></div> <p>which I quote at second hand from Morton (2003) (Bibcode: 2003ApJS..149..205M).</p> <p>Because the actual conversion (air to vacuum) is the inverse of this function, I find <tt>x</tt> such that <tt>wavelength_in_air = vacuum_to_air<img class="emoticon" src="https://pfspipe.ipmu.jp/jira/images/icons/emoticons/error.png" height="16" width="16" align="absmiddle" alt="" border="0"/></tt> by means of an iterative algorithm.</p> <p>Could you review this change (obs_pfs)?</p> <p>That's great, thanks!</p> <p>Merged. Thanks for the review.</p> Development Epic Link PIPE2D-303 Rank 0|zzstnj: Reviewers price