https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1024 DRP 2-D Pipeline <p><tt>pfsMerged</tt> fluxes are currently in electrons per wavelength sample (since the wavelength sampling is similar to the original sampling, the fluxes are roughly in units of electrons per pixel like in the pfsArm files). We agreed in the Princeton meeting today that it would be better if the <tt>pfsMerged</tt> were in units of <tt>electrons/nm</tt>.</p> <ul> <li>Change the units of the <tt>pfsMerged</tt> fluxes.</li> <li>Check that this doesn't break the calibrated fluxes in the <tt>pfsObject</tt> files.</li> <li>Document the flux units of <tt>pfsArm</tt> and <tt>pfsMerged</tt> in <tt>datamodel.txt</tt>.</li> </ul> PIPE2D-1024

Convert pfsMerged fluxes to electrons/nm

Story Major Done Done price price Thu, 14 Apr 2022 18:49:53 +0000 Fri, 10 Jun 2022 18:08:02 +0000 Fri, 10 Jun 2022 18:08:02 +0000 0 3 <p>This blocks <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe" class="user-hover" rel="kiyoto.yabe">Kiyoto Yabe</a> from his throughput analysis work.</p> <p>pfsMerged files now have flux units of electrons per nm, as demonstrated in this plot from <tt>visit=68351</tt> (a quartz with PFI):<br/> <span class="image-wrap" style=""><img src="https://pfspipe.ipmu.jp/jira/secure/attachment/15208/15208_pipe2d-1024.png" style="border: 0px solid black" /></span></p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> reduceExposure.py ~/pfs/Subaru --calib ~/pfs/Subaru/CALIB-PFI-20211220 --rerun pipe2d-1024 --id visit=68351 -j 2 -c isr.doFlat=False doAdjustDetectorMap=False doMeasureLines=False repair.doCosmicRay=False --no-versions mergeArms.py ~/pfs/Subaru --calib ~/pfs/Subaru/CALIB-PFI-20211220 --rerun pipe2d-1024 --id visit=68351 -c doSubtractSky1d=False <span class="code-keyword">import</span> matplotlib.pyplot as plt from lsst.daf.persistence <span class="code-keyword">import</span> Butler from pfs.drp.stella.interpolate <span class="code-keyword">import</span> calculateDispersion butler = Butler(<span class="code-quote">"/home/pfs/pfs/Subaru/rerun/pipe2d-1024"</span>) red = butler.get(<span class="code-quote">"pfsArm"</span>, visit=68351, arm=<span class="code-quote">"r"</span>) blue = butler.get(<span class="code-quote">"pfsArm"</span>, visit=68351, arm=<span class="code-quote">"b"</span>) merged = butler.get(<span class="code-quote">"pfsMerged"</span>, visit=68351) fiberIndex = 309 # fiberId = 339 fig, axes = plt.subplots() axes.plot(red.wavelength[fiberIndex], red.flux[fiberIndex], <span class="code-quote">"r-"</span>) axes.plot(blue.wavelength[fiberIndex], blue.flux[fiberIndex], <span class="code-quote">"b-"</span>) plt.xlabel(<span class="code-quote">"Wavelength (nm)"</span>) plt.ylabel(<span class="code-quote">"Arm flux (counts)"</span>) plt.xlim((350, 1000)) plt.twinx() plt.plot(merged.wavelength[fiberIndex], merged.flux[fiberIndex], <span class="code-quote">"k-"</span>) plt.ylabel(<span class="code-quote">"Merged flux (counts/nm)"</span>) plt.show() </pre> </div></div> <p>Oh, the <tt>isr.doApplyGains</tt> config parameter should now be left alone. Attempts to switch it on (as we have been doing) will be met with an error.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=arnaud.lefur" class="user-hover" rel="arnaud.lefur">arnaud.lefur</a>, RHL asked me to check with you that these changes don't invalidate your audit of the extractions. I think the important changes are:<br/> 1. The gains are now automatically applied; you should not (and cannot) set <tt>isr.doApplyGains=True</tt>.<br/> 2. The <tt>pfsMerged</tt> file now contains fluxes in units of electrons/nm. The normalisation has also changed to be in the same units, so that the normalised flux is consistent with what it was previously.</p> <p>My opinion is that these changes should not change any of your conclusions, but please correct me if I am wrong.</p> <p>Code review complete. Only minor comment about units for <tt>pfsMerged</tt> files being in <tt>electron/nm</tt> rather than <tt>counts/nm</tt>.</p> <p>Given that <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=arnaud.lefur" class="user-hover" rel="arnaud.lefur">arnaud.lefur</a> will not have time to perform his audit for the next week or so with the June Engineering Run looming, and that this issue is blocking for <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe" class="user-hover" rel="kiyoto.yabe">Kiyoto Yabe</a>, we will proceed to merge the proposed changes to master. Arnaud can perform his audit when he is next available, as part of a separate ticket. Thus any problems he may find will be addressed as part of that separate ticket.</p> <p>Merged.</p> Relates DAMD-97 PIPE2D-1008 Development Rank 0|02qpjd:00xznup2c4 Reviewers hassan Sprint 2DDRP-2022 D 2DDRP-2022 E Story Points 2.0