https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1021 DRP 2-D Pipeline <p><tt>FitPfsFluxReferenceTask</tt> does not write its result object. There should be something like <tt>calculateReferenceFlux.py</tt>, which calls <tt>FitPfsFluxReferenceTask</tt> and writes the returned object.</p> PIPE2D-1021

Add executable that calls FitPfsFluxReferenceTask

Task Normal Done Done sogo.mineo sogo.mineo flux-calibration Mon, 11 Apr 2022 02:56:05 +0000 Mon, 6 Jun 2022 02:52:52 +0000 Wed, 13 Apr 2022 01:33:50 +0000 0 2 <p>I don't think of a good reason to make a separate task that wraps <tt>FitPfsFluxReferenceTask</tt>. I am to convert <tt>FitPfsFluxReferenceTask</tt> itself into an executable if it is possible.</p> <p>Sounds good.</p> <p>Could you review these two PRs?</p> <p>The added executable (<tt>bin/fitPfsFluxReferenceTask.py</tt>) does not run successfully if I input the files of the integration test, because the task requires two or more broad-band fluxes for FLUXSTD spectra. However, the validity of the whole code except for file IO is tested by the unit test (which is left unchanged), and I have made sure by experiments that the output file would actually be written through the butler if the instruction pointer were to arrive at <tt>dataRef.put(...)</tt>.</p> <p>Merged. Thanks for the review.</p> Development Epic Link PIPE2D-303 Rank 0|zzstjb: Reviewers price