<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:01:25 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[PIPE2D-1012] Quality of FluxModelInterpolator&apos;s output is bad</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1012</link>
                <project id="10002" key="PIPE2D">DRP 2-D Pipeline</project>
                    <description>&lt;p&gt;The quality of FluxModelInterpolator&apos;s output is evidently bad.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;truth vs interpolation.png&amp;#93;&lt;/span&gt; FluxModelInterpolator cannot even reproduce one of the input points. Since this is interpolation, such a phenomenon should not be observed if calculations are exact.&lt;/p&gt;

&lt;p&gt;&lt;span class=&quot;error&quot;&gt;&amp;#91;fullset vs modelInterpolator.png&amp;#93;&lt;/span&gt;FluxModelInterpolator cannot reproduce the interpolation &quot;fullset&quot;) that Yamashita-san made.&lt;/p&gt;

&lt;p&gt;According to Yamashita-san, the current FluxModelInterpolator works differently from what his interpolator did because he had forgot to upload his latest code to &lt;tt&gt;drp_fstar&lt;/tt&gt;&#160;repository before FluxModelInterpolator was made.&lt;/p&gt;

&lt;p&gt;However, I made some experiments and concluded that it was the oldness of scipy that was to blame. In addition, the latest scipy introduced &lt;tt&gt;RBFInterpolator&lt;/tt&gt; that is very useful to FluxModelInterpolator. Currently, FluxModelInterpolator uses &lt;tt&gt;Rbf&lt;/tt&gt; class, whose codomain must be one-dimensional in our old scipy. It uses 100k &lt;tt&gt;Rbf&lt;/tt&gt; instances to output a spectrum with 100k sampling points. On the other hand, &lt;tt&gt;RBFInterpolator&lt;/tt&gt;&apos;s codomain can be multidimensional. If it is used, computation will be 100k times faster as I have already confirmed personally.&lt;/p&gt;

&lt;p&gt;Because I don&apos;t think the latest scipy (&amp;gt;= 1.8) will be available very soon, I am going to write a small implementation of &lt;tt&gt;RBFInterpolator&lt;/tt&gt; compatible with scipy. After&#160;scipy &amp;gt;= 1.8 is available, the compatible class must be abandoned.&lt;/p&gt;</description>
                <environment></environment>
        <key id="22700">PIPE2D-1012</key>
            <summary>Quality of FluxModelInterpolator&apos;s output is bad</summary>
                <type id="3" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10518&amp;avatarType=issuetype">Task</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="sogo.mineo">sogo.mineo</assignee>
                                    <reporter username="sogo.mineo">sogo.mineo</reporter>
                        <labels>
                            <label>flux-calibration</label>
                    </labels>
                <created>Mon, 28 Mar 2022 03:58:37 +0000</created>
                <updated>Wed, 8 Jun 2022 00:27:40 +0000</updated>
                            <resolved>Wed, 8 Jun 2022 00:27:40 +0000</resolved>
                                                                        <due></due>
                            <votes>0</votes>
                                    <watches>4</watches>
                                                                <comments>
                            <comment id="30630" author="price" created="Mon, 28 Mar 2022 13:53:20 +0000"  >&lt;p&gt;scipy 1.8.0 is available with an updated LSST stack (&lt;a href=&quot;https://pfspipe.ipmu.jp/jira/browse/PIPE2D-598&quot; title=&quot;Upgrade base LSST stack to latest version&quot; class=&quot;issue-link&quot; data-issue-key=&quot;PIPE2D-598&quot;&gt;&lt;del&gt;PIPE2D-598&lt;/del&gt;&lt;/a&gt;). I hope to complete the update soon, so please do not go to any trouble here.&lt;/p&gt;</comment>
                            <comment id="30634" author="sogo.mineo" created="Tue, 29 Mar 2022 05:36:06 +0000"  >&lt;p&gt;OK. Then I will wait for scipy 1.8.0. I want to keep this issue open because I will in this ticket replace &lt;tt&gt;Rbf&lt;/tt&gt; class with &lt;tt&gt;RbfInterpolator&lt;/tt&gt; class when it gets available.&lt;/p&gt;</comment>
                            <comment id="30775" author="sogo.mineo" created="Tue, 26 Apr 2022 03:13:33 +0000"  >&lt;p&gt;I pushed a branch for this ticket because Yamashita-san wants to try RBFInterpolator. The branch currently contains RBFInterpolator that I myself wrote. This class will be deleted in future when scipy is upgraded, before this branch is merged to master.&lt;/p&gt;</comment>
                            <comment id="30993" author="sogo.mineo" created="Tue, 7 Jun 2022 07:10:23 +0000"  >&lt;p&gt;Could you review this PR?&lt;/p&gt;</comment>
                            <comment id="30998" author="sogo.mineo" created="Wed, 8 Jun 2022 00:27:40 +0000"  >&lt;p&gt;Merged. Thanks for review.&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                            <attachment id="15142" name="fullset vs modelInterpolator.png" size="55251" author="sogo.mineo" created="Mon, 28 Mar 2022 03:31:15 +0000"/>
                            <attachment id="15143" name="truth vs interpolation.png" size="42718" author="sogo.mineo" created="Mon, 28 Mar 2022 03:21:37 +0000"/>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10006" key="com.pyxis.greenhopper.jira:gh-epic-link">
                        <customfieldname>Epic Link</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>PIPE2D-303</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qpjd:c</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>price</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                </customfields>
    </item>
</channel>
</rss>