PFS-JIRA

PFS-JIRA https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us

8.3.4

803005

13-09-2019

[PIPE1D-71] Update for drp1d 0.42.0 https://pfspipe.ipmu.jp/jira/browse/PIPE1D-71 DRP 1D pipeline PIPE1D-71

Update for drp1d 0.42.0

Task Normal Done Done Ali Allaoui Ali Allaoui Thu, 15 Jun 2023 15:46:59 +0000 Wed, 10 Jan 2024 21:37:27 +0000 Wed, 10 Jan 2024 21:37:27 +0000 drp_1dpipe Mon, 19 Jun 2023 00:00:00 +0900 0 2 Sorry, it took some time. I didn't notice the new requirements on `eigen` and `lbfgspp` ... I checked installation of the new version, but could you fix <a href="https://github.com/Subaru-PFS/drp_1dpipe/blob/tickets/PIPE1D-71/drp_1dpipe/__init__.py" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/drp_1dpipe/blob/tickets/PIPE1D-71/drp_1dpipe/__init__.py</a> to the newer version. After fixing this, the installation was successful. The validation failed but it seems that D1DP_VER=0.40.0 in the validation products, so this may cause the failure. Could you check this as well please? Apologize for not telling you about the new requirements. I updated version number of drp1d_pipe and merged <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE1D-71" title="Update for drp1d 0.42.0" class="issue-link" data-issue-key="PIPE1D-71"><del>PIPE1D-71</del></a> into master, and also updated the datapack with the correct version number. Everything should be in order now Thank you for the update! The installation is now OK. I see some difference in the validation. Mostly very tiny numerical difference but this time I see this. <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> (lsst-scipipe-3.0.0) bash-4.2$ fitsdiff pfsZcandidates-00006-00000-0,0-00000000001e8527-002-0x11fcdfd13c364618.fits ../../validation/data/pfsZcandidates-00006-00000-0,0-00000000001e8527-002-0x11fcdfd13c364618.fits fitsdiff: 4.1 a: pfsZcandidates-00006-00000-0,0-00000000001e8527-002-0x11fcdfd13c364618.fits b: ../../validation/data/pfsZcandidates-00006-00000-0,0-00000000001e8527-002-0x11fcdfd13c364618.fits Maximum number of different data values to be reported: 10 Relative tolerance: 0.0, Absolute tolerance: 0.0Primary HDU: Headers contain differences: Keyword GALAXY_LWARNING has different values: a> 8388608 b> 0 </pre> </div></div> I'll take a look closer and I will try to think about how to reproduce in your side. <tt>Can you send me the test_output directory so I can check differences and log ?</tt> <tt>These differences can be normal, including the change in the line measurement warning flag, as the new line flux measurement algorithm is very sensitive</tt> Thanks! I put the directory here: <a href="https://pfs.ipmu.jp/internal/devarch/ipmu/tmp/test_output/" class="external-link" rel="nofollow">https://pfs.ipmu.jp/internal/devarch/ipmu/tmp/test_output/</a> Now I see some internal errors in the log, which were not seen during the processing. Now the validation problem is discussed in a different ticket, so this ticket will be closed. Development Rank 0|zzsxz3: Reviewers kiyoto.yabe