https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-864 Instrument control development <p>Once we have the IIC commands to control the SPS, add the published ones to the Gen2 interface files.</p> INSTRM-864

Create Gen2 entrypoints for *published* IIC commands which control SPS

Task Normal Done Done yuki.moritani cloomis EngRun SPS Wed, 18 Dec 2019 22:54:18 +0000 Thu, 14 Oct 2021 17:40:10 +0000 Thu, 30 Sep 2021 22:36:59 +0000 ics_gen2Actor PFS_kansoku 0 4 <p>Looking the published commands, I think the following are needed for eng./sci. observations:</p> <ul> <li>doExpose</li> <li>doBias</li> <li>doDark</li> <li>doArc (to use the engineering fibers)</li> <li>custom</li> <li>abort</li> </ul> <p>I think the following are needed, but using with PFIlamp.</p> <ul> <li>ditheredFlats</li> <li>ditheredArcs</li> </ul> <p>I'm not sure if we need to execute the following from Gen2 (probably not):</p> <ul> <li>doFlat (as it is for DCB)</li> <li>slitThroughFocus</li> <li>detThroughFocus</li> </ul> <p> </p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=arnaud.lefur" class="user-hover" rel="arnaud.lefur">arnaud.lefur</a>  I have a few questions.</p> <ol> <li>Is it possible to execute dither commands without turning on any dcb lamp? It seems that halogen will be on for flat...</li> <li>Shutter is controlled automatically for individual exposure type (object, dark, bias). Is this correct?</li> <li>How do you tread medium resolution? I guess currently defined cameras are b1 or r1 (no m1)... and I couldn't find how a command to move the red grating other than 'custom' command...</li> </ol> <ol> <li>you're right for ditheredFlats I'm automatically switching on halogen, once we got PFIlamp we'll need to treat this differently.</li> <li>that's correct.</li> <li>it hasn't been specifically treated yet, but there soon will be a <b>sps go low/med</b> command. </li> </ol> <p>Thank you for your answers, Arnaud. I'll then work on the first group now...</p> <p> </p> <p>I have come up with another question...   Commas "," are used in the option (parameter) <em>cam</em>  (<em>cam=b1,r1</em> for instance), but I'm afraid comma is reserved letter in .sk file.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=eric" class="user-hover" rel="eric">eric</a> , is it correct that commas are used only at the end of line (async command) it is prohibited to use anywhere else? I mean, doesn't it work?</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> :Parameter CAMERA=<span class="code-quote">"b1,r1"</span> ... :main_start Exec PFS PFSCMD ACTOR=<span class="code-quote">"iic"</span> CMD=<span class="code-quote">"bias cam=$CAMERA (I skip other parameters)"</span> ...</pre> </div></div> <p>Commas are no problem inside strings. So if you pass a quoted string there will be no problem.</p> <p>I understood it. Thank you.</p> <p>to clarify, your command here should be fine.</p> <p><em>comment by</em> <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=yuki.moritani" class="user-hover" rel="yuki.moritani">yuki.moritani</a>  <em>on 26/Aug/21 4:40 AM, copied over from <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-865" title="Create Gen2 entrypoints for *engineering* SPS commands" class="issue-link" data-issue-key="INSTRM-865"><del>INSTRM-865</del></a>:</em> <br/>  <br/> For Engineering run in September 2021, the following command needs to be developed</p> <ul> <li>IIC entry points for arc/trace/dithered-flat acquisition using pfi lamp, which is analogy of DCB data acquisition.</li> </ul> <p><em>comment by</em> <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> <em>on 26/Aug/21 6:44 AM, copied over from <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-865" title="Create Gen2 entrypoints for *engineering* SPS commands" class="issue-link" data-issue-key="INSTRM-865"><del>INSTRM-865</del></a>:</em><br/>  <br/> I think Arnaud and I are hoping that DCB and pfilamps are similar enough that we will not need different IIC commands. Basically, if the commanded SMs are all connected to the PFI or to the DCB, the iicActor and spsActor will control the appropriate light source with the same commands. If they are not, the IIC command will be rejected.</p> <p>I believe that the only significant differences are that one light source has an HgCd lamp and the other an HgAr lamp, and that we need to make sure that the pfilamps never get turned on when inappropriate. I don't think either merits separate commands.</p> <p>Does that make sense?</p> <p><em>comment by <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=yuki.moritani" class="user-hover" rel="yuki.moritani">yuki.moritani</a> on 26/Aug/21 7:33 PM, copied over from <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-865" title="Create Gen2 entrypoints for *engineering* SPS commands" class="issue-link" data-issue-key="INSTRM-865"><del>INSTRM-865</del></a>:</em><br/>  </p> <p>OK, it is cared with <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1342" title="make IIC arc/flat compatible with dcb/pfilamps" class="issue-link" data-issue-key="INSTRM-1342"><del>INSTRM-1342</del></a></p> <p>How do you treat fan control? Could you remind me that you always turn on/off per exposure, or keep the lamp on in a sequence?</p> <p><em>comment by</em> <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> <em>on 26/Aug/21 7:42 PM, copied over from <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-865" title="Create Gen2 entrypoints for *engineering* SPS commands" class="issue-link" data-issue-key="INSTRM-865"><del>INSTRM-865</del></a></em><br/>  <br/> The fan is controlled automatically by the core pfilamps pi code. Warmup for subsequent HgCd exposures can be shorter, but that is handled between the sps and pfilamps actors: the spsActor does not have to wait as long.</p> <p>OK, yes, part of <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1342" title="make IIC arc/flat compatible with dcb/pfilamps" class="issue-link" data-issue-key="INSTRM-1342"><del>INSTRM-1342</del></a> is to handle waiting for the lamps to become ready.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=eric" class="user-hover" rel="eric">eric</a> I have one question about handling double-quotation</p> <p>to take SpS exposure OFS command is as follows</p> <blockquote><p>oneCmd.py iic scienceTrace halogen=300 name="pfiLamps" comments="testing exposure time"</p></blockquote> <p>Using DD command, this should be passed as follows.</p> <blockquote><p>exec pfs pfscmd actor=ics cmd="scienceTrace halogen=300 name="pfiLamps" comments="testing exposure time""</p></blockquote> <p>That is, double-quotation needs to be passed.<br/> Could you tell how to do it? When I tried to pass double quotation using back-slash for DD command to set message, it failed.</p> <p> </p> <p>I agree that we need to know how to nest quoted strings, but I also think that for this particular ticket ("... published IIC commands...") we cannot use the <tt>pfscmd</tt> mechanism: all the primary observing commands need dedicated <tt>PARA</tt> commands. That would allow, in this case, <tt>exec pfs scienceTrace halogen=300 name="pfiLamps" comment="testing exposure time"</tt>.</p> <p>We still intend to disable <tt>pfscmd</tt> during normal operations, right?</p> <p>OK. I didn't know or forgot your plan...</p> <p>I agree to the idea to create dedicated DD command for science operation, but for engineering run (it is nice to have, indeed,), but you may want to use the current <tt>pfscmd</tt> command for the time being, as we took MCS data in 2019...?</p> <p>Quick answer: use square bracket quotes:</p> <p> </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>exec pfs pfscmd actor=ics cmd=[scienceTrace halogen=300 name="pfiLamps" comments="testing exposure time"]   </pre> </div></div> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">  </pre> </div></div> <p>In the long run, I will enhance the lexer to handle escaped nested quotes.</p> <p>I've modified the lexer to handle single and double quotes, with nested escapes.  So you can now do:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> exec pfs pfscmd actor=ics cmd=<span class="code-quote">'scienceTrace halogen=300 name=<span class="code-quote">"pfiLamps"</span> comments=<span class="code-quote">"testing exposure time"</span>'</span></pre> </div></div> <p>if you prefer.</p> <p>Strings are interpolated in oscript, and interpolation characters &amp;, ! and @ need to be double-escaped to pass through the decoder. So if you need to pass one of these three characters, use double backslash <br/> preceding it.</p> <p>As basic (primitive) gen2 .sk command was made for September run, I close this ticket for now.</p> <p>For real operation, more dedicated entrypoints (.dd commands) are needed, rather than just passing iic commands.</p> Blocks INSTRM-778 INSTRM-789 INSTRM-1342 Development Rank 0|02qpuc:i6001gr068fhw9qo4o2 Sprint EngRun03 Story Points 3.0