https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-711 Instrument control development <p>As discussed in last ICS/DRP+SpS telecon 2019-07-10, instead of the full alertsActor implementation of <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-451" title="Implement and use alertsActor for LAM AIT" class="issue-link" data-issue-key="INSTRM-451"><del>INSTRM-451</del></a>, implement a simplified solution where the actor reads a YAML file with threshold and apply those thresholds to generate STS keywords.</p> INSTRM-711

Implement Simplified alertsActor for LAM AIT

Story Major Done Done arnaud.lefur hassan SM1 Tue, 16 Jul 2019 12:49:37 +0000 Tue, 27 Aug 2019 15:47:37 +0000 Thu, 22 Aug 2019 09:27:59 +0000 ics_alertsActor 0 2 <p>Specifically, there is a template config file for alerts in <tt>config/keywordAlerts.py</tt>, and I suggest that we implement <em>only</em> the <tt>limitsAlert</tt> part. E.g.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> meb: # MCS E-Box flow: &lt;&lt;: *LIMITS_ALERT limits: [0.0, null] alertFmt: 'coolant flow has stopped' temps[0]: &lt;&lt;: *LIMITS_ALERT limits: [10.0, 25.0] alertFmt: 'temperature out of range' xcu_{cam}: # All XCUs pcmPower[bus1]: &lt;&lt;: *LIMITS_ALERT limits: [23.5, null] alertFmt: 'Input power is failing!!: {value}V' pcmPower[bus2]: &lt;&lt;: *LIMITS_ALERT limits: [23.5, null] alertFmt: 'Input power is failing!!: {value}V' </pre> </div></div> <p>And I'll point out <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-311" title="Fix when condition in hwraid role" class="issue-link" data-issue-key="INSTRM-311"><del>INSTRM-311</del></a>. I believe that this is the sane thing to do:</p> <ul class="alternate" type="square"> <li>make <em>all</em> STS types STRING+INTEGER or STRING+FLOAT.</li> <li>make that STRING "OK" or something useful to a human</li> <li>STS logic <em>only</em> looks at the OK/other (and a couple of timeouts)</li> </ul> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a>: Is your proposal above for the <tt>alertFmt</tt> in <tt>config/keywordAlerts.yaml</tt> ? And then regarding the STS logic, would that be a configuration for the 'real' STS server? </p> <p>Yes. Exactly the same logic for both the fake and the real STS server. I don't think the alertsActor can tell the difference.</p> <p>Note that the actor is currently using the simpler <tt>STS.yaml</tt>, where the magic integers are the assigned STS IDs. I think we should merge <tt>STS.yaml</tt> and the more expressive <tt>keywordAlerts.yaml</tt> Obviously for "STRING+FLOAT" above I should have written "FLOAT+TEXT".</p> <p>The existing <tt>Controllers/actorRules.py</tt> wires the <tt>STS.yaml</tt> keywords to automatically forward to the STS server when they get updated. It actually already checks whether there is an entry in <tt>.actor.activeAlerts</tt> and forwards that instead of "OK". We need to also wire in any limit, etc. checks, which just need to set the entry in <tt>actor.activeAlerts</tt>. </p> <p>Note also that we probably do not need to debounce or latch errors, since the STS server does that for us. That is a pretty significant simplification. I.e. if a key field goes back within its limits, we can simply set it back to "OK" &#8211; the STS server will deal with the latching and give the human a way to clean and rearm. Very nice.</p> <p>Alerts should be generated on the main pressures, temperatures and voltages.</p> Relates INSTRM-451 Development Rank 0|02qpuc:i6001gzi Reviewers cloomis Sprint SM1-2019 K SM1-2019 L SM1-2019 M Story Points 2.0