https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-528 Instrument control development <p>The FITS <tt>OBS-MOD</tt> card is filled in from the kansoku <tt>sk</tt> sub-directory names. We have been using that to indicate "ENG"ineering. Turns out that values are limited to those negotiated with NOAJ <img class="emoticon" src="https://pfspipe.ipmu.jp/jira/images/icons/emoticons/help_16.png" height="16" width="16" align="absmiddle" alt="" border="0"/>. </p> <p>We need to work this out.</p> INSTRM-528

Constrain PFS kansoku script directories to allowed FITS.PFS.OBS-MOD values.

Task Normal Done Done yuki.moritani cloomis FITS Tue, 16 Oct 2018 20:40:21 +0000 Sat, 18 Sep 2021 22:00:30 +0000 Sat, 18 Sep 2021 07:34:05 +0000 PFS_kansoku 0 7 <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> should this issue have the <tt>MCS</tt> label?</p> <p>In the v7.0 NAOJ FITS bible, Sections 9.1 and 10.1 address <tt>OBS-MOD</tt> values and thus (as I understand it) possible <tt>sk</tt> directory names. Do we need to change the directory names to "IMAG" for some scripts and "SPEC" for others? Not sure I understand. <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=furu" class="user-hover" rel="furu">Hisanori Furusawa</a>?</p> <p>I'm sorry I didn't noticed The book claim that you can put anything by putting "_" after allowed words.</p> <p>Following it, I'd propose "SPEC_ENG". (PFS has only spectrograph mode, so I think we should keep SPEC to every images.)</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> Basically, yes. The abstract commands should be grouped separately for imaging and spectrograph modes so that the corresponding skeleton files are located under relevant directories that are named one of IMAGE(_<em>&#42;), SPEC(</em><em>&#42;), IPOL(</em><em>&#42;), and SPOL(</em>_&#42;). There are some exceptions with the existing instruments due to some historical reason (in some cases, the rule was simply overlooked unfortunately), and now Gen2 &amp; FITS teams at the observatory are figuring out how to mitigate those violations on the Gen2 code side. This is an undesired exception handling, so we want to avoid this as much as possible with the active and future instruments.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=furu" class="user-hover" rel="furu">Hisanori Furusawa</a> , thank you for telling the background. Then, as long as we start with <b>SPEC_</b>  , ** is there no other convention to follow? (I thing yes, reading FITS bible ver 7.0.). I will change PFS kansoku scripts accordingly after our run this week.</p> <p> </p> <p>To my understanding, there is no other mandatory convention, as long as a registered value is used for consistently the same meaning. There might be some offline discussion of a practical convention recently. I hope <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=monodera" class="user-hover" rel="monodera">monodera</a> could comment on this.</p> <p>You can also put a special assignment in the header of an observation script to override the directory name so that the FITS.PFS.OBS-MOD will be set correctly.  We added that for some of the older instruments who had used "non-standard" directory names (e.g. "LAUNCHER", "ENG", etc.)</p> <p> </p> <p>As long as the OBS-MOD starts with one of "IMAGE", "SPEC", "IPOL", and "SPOL" followed by "_", there is no particular convention. "SPEC_ENG" meets the regulation but it looks to me too generic as one cannot distinguish whether the data are for engineering for MCS, SM, other modules, or even combination of more than one. On the other hand, making different OBS-MOD for different types of engineering (e.g, SPEC_ENG_MCS, SPEC_ENG_SM1, etc) could be even more complicated. </p> <p>For example, SMOKA lists some details of engineering observations (<a href="https://smoka.nao.ac.jp/ENG/ENGschedule.jsp" class="external-link" rel="nofollow">https://smoka.nao.ac.jp/ENG/ENGschedule.jsp</a>). It would be helpful if PFS can do the same, while just using "SPEC_ENG" for OBS-MOD.</p> <p>(For recording)<br/> I have implemented a line "OBE_MODE=SPEC_ENG" to overwrite OBS-MOD status. <br/> We'll check the header when we can run Gen2 command on Gen2 simulator (or summit system) next time.</p> <p>I tested the new commands during the engineering run03, but r was found the correct parameter is OBS_MODE, not OBE_MODE. Eric-san pointed out that if you run the command via launcher, overwriting function sometimes may not work.<br/> So I'll modify the directory name to avoid any confusion..</p> <p>&gt; I tested the new commands during the engineering run03, but r was found the correct parameter is OBS_MODE, not OBE_MODE.</p> <p> </p> <p>Just to prevent any confusion: the correct keyword is "OBS_MOD" not "OBS_MODE"</p> <p> </p> Development Rank 0|s001c0: