https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-424 Instrument control development <p>The `drpActor` was created a long long time ago. Make sure it matches the current system. </p> INSTRM-424

Update drpActor to match current PFS DRP.

Task Normal Done Done cloomis cloomis SM1 Mon, 23 Jul 2018 13:55:41 +0000 Wed, 15 May 2019 12:46:17 +0000 Tue, 14 May 2019 21:21:56 +0000 Fri, 27 Jul 2018 00:00:00 +0900 0 5 <p>Quick update : We still have an issue with the DetrendTask:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>command failed: AssertionError() at /opt/lsst/software/stack/stack/miniconda3-4.3.21-10a4fa6/Linux64/base/16.0/python/lsst/base/packages.py:156</pre> </div></div> <p>However, it's working when we are using subprocess to call detrend.py;</p> <p>It's not very elegant but I guess that's fine for now. </p> <p> </p> <p> </p> <p>I think we solved that with the work on Dec. 20, and the master <tt>Dockerfile.icsdrp</tt> contains the change.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=arnaud.lefur" class="user-hover" rel="arnaud.lefur">arnaud.lefur</a>, <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=fmadec" class="user-hover" rel="fmadec">fmadec</a>: can you check the docker image to confirm the fix? Then we can close this ticket.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=fmadec" class="user-hover" rel="fmadec">fmadec</a> will be checking this shortly (~10 Feb)</p> <p>We just tried the latest master pfs-pipe2d using the docker icsdrp</p> <p>and we still have the same issue:</p> <p> </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>root INFO: Running: lsst.pipe.base.cmdLineTask.DetrendTask.parseAndRun('/drp/r1', '-calib=/drp/r1/CALIB', 'rerun=ginga/detrend', 'doraise', 'clobber-versions', '-id', 'visit=11909') 2019-02-11 10:38:23.542Z cmds 20 CommandLink.py:121 &gt; 1 2 f text="command failed: AssertionError() at /opt/lsst/software/stack/stack/miniconda3-4.3.21-10a4fa6/Linux64/base/16.0/python/lsst/base/packages.py:156"</pre> </div></div> <p>Craig needs to run it at IDG to determine what the problem is. </p> <p>As LAM have a workaround, this is not critical.</p> <p>Grr. We got past the python environment problems, but have run into a conflict between <tt>lsst.base.packages.getPythonPackages()</tt> and the (non-standard <tt>twisted.<em>version.</em><em>version</em>_</tt>, which is an object and not a string, and which triggers an AssertionError.</p> <p>The fix requires a change to <tt>lsst.base</tt> &#8212; I'll try to negotiate something.</p> <p>In the meanwhile, we need to add the following to the end of <tt>lsst.base.packages.getVersionFromPythonModule</tt>:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>if not isinstance(version, str): raise ValueError('version is not a string') </pre> </div></div> <p>detrend now works fine with the new patch <img class="emoticon" src="https://pfspipe.ipmu.jp/jira/images/icons/emoticons/thumbs_up.png" height="16" width="16" align="absmiddle" alt="" border="0"/>.</p> <p>It has been merged to master and tagged as 0.0.9</p> <p>pfs_piped merged at 8e0d1bd (Dockerfile.icsdrp changes)<br/> ics_drpActor merged at a97d3f8 (monkeypatch for twisted _<em>version</em>_)</p> <p>Looks like the ics_drpActor change made on the <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-424" title="Update drpActor to match current PFS DRP." class="issue-link" data-issue-key="INSTRM-424"><del>INSTRM-424</del></a> branch was merged in such a way that it lost the branch ref.</p> Development Rank 0|u0009r:zzzzy1z4 Sprint SM1-2019 G Story Points 3.0