https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-388 Instrument control development <p>I believe we are required by Subaru to have WCS cards. We could, in operations, have pixel &#8211; sky transforms. We probably always want pixel &#8211; focal plane (mm)?</p> <p>Per <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-484" title="Update FITS headers based on Subaru feedback of MCS example PFSC00005800" class="issue-link" data-issue-key="INSTRM-484"><del>INSTRM-484</del></a>, this must go in HDU1, with the image.</p> <p>We don't have rotation yet, but will.</p> INSTRM-388

Create WCS cards for MCS images.

Task Normal Done Done yuki.moritani cloomis MCS Wed, 20 Jun 2018 14:55:13 +0000 Tue, 16 Oct 2018 06:21:20 +0000 Sun, 14 Oct 2018 07:03:39 +0000 ics_mcsActor 0 3 <p>The distortion routines freshly put into `pfs_utils` have sky-to-mcs, mcs-to-pfi, and pfi-to-mcs. We can probably use these to generate pretty good WCS solutions for both maps.</p> <p>This covers items 2, part of 19, 20, 24 from <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-388" title="Create WCS cards for MCS images." class="issue-link" data-issue-key="INSTRM-388"><del>INSTRM-388</del></a></p> <p>Can we add, say, <tt>genWCS(rot, alt)</tt> routines to <tt>pfsutils.coordinates</tt>? I do not know enough to recommend WCS python modules, but the ICS environment does include <tt>astropy</tt>, which has <tt>astropy.wcs</tt>.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=yuki.moritani" class="user-hover" rel="yuki.moritani">yuki.moritani</a>: I've re-assigned this issue to you as you have coordinate transformation experience. Please contact <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> or <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=chyan" class="user-hover" rel="chyan">chyan</a> if you need support on WCS matters.</p> <p>Well, the current distortion routines treat symmetric scaling and deviation from scaling separately, so we my be able to start with using the former as a first step.</p> <p>The scaling part is called</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-comment">// def ScalingFactor(xyin, c):</span> </pre> </div></div> <p>and it consists of polynomials and residual. I think we can also skip residual, which I used interpolation.</p> <p>So, as a first step, we could create WCS card by</p> <ul> <li>Referring the PFI center position on MCS</li> <li>Referring the coefficients of polynomials <tt>dis_rsc</tt> for the symmetric scaling</li> </ul> <p> What do you think? <br/> I think distortion coefficients will be accommodated in a separate place from script itself (<a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-277" title="Save F3C to MCS distortion map version and/or coeffs" class="issue-link" data-issue-key="INSTRM-277"><del>INSTRM-277</del></a>), I guess the above can be done without distortion routine.</p> <p>Agreed, and I'd even go further: linear is probably fine for now.</p> <p>The routines documented in <a href="http://docs.astropy.org/en/stable/wcs/#building-a-wcs-structure-programmatically" class="external-link" rel="nofollow">http://docs.astropy.org/en/stable/wcs/#building-a-wcs-structure-programmatically</a> are probably what we should use.</p> <p>Thank you for the pointer. I'll read it and put a draft here later.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> I pushed a code to treat this, although I claimed "TBD" for world coordinates.</p> <p>It is called with mode (the same as the coordinate code), center position, alt and az, like</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> MakeWCSCards.WCSParameters(<span class="code-quote">"mcs_pfi"</span>, [centx,centy], 0., 90. , 0.]</pre> </div></div> <p>The all angles are in degree.<br/> It returns WCS and SIP parameters.</p> <p>Could you see if it is what you expect so far?</p> <p>At first glance that looks perfect. [ I'll push a couple of tiny changes to your branch ]</p> Blocks INSTRM-466 Relates INSTRM-525 Development Epic Link INSTRM-484 Rank 0|ii015w:r