https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-2162 Instrument control development <p>Some products when get installed, get wrongly assigned dirty tag.</p> <ul> <li>When some binaries get built</li> <li>ics_actorkeys<br/> If we are to throw warnings, this needs to be fixed first.</li> </ul> INSTRM-2162

Fix false dirty tag after pfsinstall

Task Normal Open Unresolved Unassigned arnaud.lefur EngRun Wed, 31 Jan 2024 19:10:18 +0000 Fri, 2 Feb 2024 15:45:08 +0000 0 2 <p>Historically, most MHS products had a <tt>setup.py}}file, which is then what {{pfsinstall/eupsinstall</tt> used. Some products now have <tt>SConstruct</tt> files, which <tt>eupsinstall</tt> will always use in preference to <tt>setup.py</tt> if it is available. For all those products, installed versions do <b>not</b> have a <tt>.git</tt> directory, and will never see <tt>-dirty</tt>. For those, we are fine.</p> <p>A few products have neither <tt>setup.py</tt> nor <tt>SConstruct</tt> file, in which case <tt>eupsinstall</tt> will <tt>cp -r</tt> the entire directory in. Those products will <b>always</b> show <tt>-dirty</tt>, because <tt>eupsinstall</tt> then updates the <tt>.table</tt> file with the frozen eups versions. For the products in this group which are simply pure-python we can just add <tt>SConstruct/setup.py</tt> files. Umm, <tt>ics_actorkeys</tt> is one example.</p> <p>The harder products are the ones which do not have <tt>setup.py</tt> files because they require fancier builds (oh, cython, vendor libraries/binaries, kernel modules) and I was too weak to face the work of packaging them "right". Umm, <tt>ics_mcsActor, ics_rtdADIO, ics_xcu_fpga, hxhal</tt> are the obvious ones. But those are it, I think. </p> <p>And I'll clarify the ticket description a bit....</p> <p><tt>pfsinstall</tt> will only install from a git tag, and except for the optional trailing letter for unchanged revisions on top of updated dependencies, the installed <tt>eups</tt> version will always be the <tt>git</tt> tag.</p> <p>The actors <tt>version</tt> command tries to generate both <tt>git describe</tt> and <tt>eups list</tt> version for each setup product. If the git version is available, that is the one which is preferred (has more information, including <tt>-dirty</tt> and the number of revisions since the last tag). Otherwise the <tt>eups</tt> version is used. For PFS that is usually the <tt>git</tt> version as described above. For LSST it is now some crazy pair of SHAs and the real version is in a less accessible <tt>eups</tt> tag.</p> Relates INSTRM-2161 Development Rank 0|02qph7:06r0900009