https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-206 Instrument control development <p>before configure and make, eups role shall check git checkout is updated or not, and be better not to run configure/make etc. when cloned one is not updated.</p> INSTRM-206

eups role shall check git updated or not

Task Normal Done Done shimono shimono Fri, 22 Sep 2017 16:30:28 +0000 Wed, 21 Feb 2018 20:28:44 +0000 Wed, 21 Feb 2018 20:28:44 +0000 ics_ansible 0 2 <p>git module output changed=true for local updated.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>TASK [dnsmasq : Checkout ics_dnsmasq repository] ******************************* task path: /data1/shimono/git/github-pfs/ics_ansible/roles/dnsmasq/tasks/main.yml:16 changed: [lf01] =&gt; {"after": "943ea3df75a422330272e65933a1eb08b3a8f89e", "before": "e620607fa369b74fe3ac3e5ec60d341e5fe01749", "changed": true, "warnings": []} </pre> </div></div> <p>Slightly puzzled here. A specific tagged version of eups is being installed (<tt>vars/main.yml: eups.version</tt>). So why would we care about the git repo getting changed? If we were running off a branch or master, sure.</p> <p>I've added this flag not to run configure/make, as in description of ticket.<br/> It should not change results (built binary/installation etc.), but building things more than twice is just a waste of time...</p> <p>I'd like to state that I do not think that this kind of ticket needs a proper review. This is just a straightforward technical fix, and you should feel free to simply make it and close the ticket.</p> <p>I am not sure where is the line for straightforward fix or not, one line fix could be a straightforward fix sometimes but not for sometimes. For this one, I can agree this is just a technical bug, but still it should be important to be reviewed not to introduce any regression...</p> <p>merged.</p> Development Rank 0|ii031b: Sprint 2017-10A