<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:41:53 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[INSTRM-1993] Fix pixel drops at start of ramps</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/INSTRM-1993</link>
                <project id="10300" key="INSTRM">Instrument control development</project>
                    <description>&lt;p&gt;Ramps sporadically fail, where the actor cannot get enough pixels from the DAQ to complete the ramp. There is no per-read framing, so this is only discovered at the end of the ramp, and the drops could have come anytime.&lt;/p&gt;

&lt;p&gt;On n1 at Subaru, we are seeing quite a few of these: 19/516 from 2023-05 to now, ~4%. It turns out that most/all ramps are simply missing pixels at the &lt;b&gt;beginning&lt;/b&gt; of the ramp, visible even in the RESET frame. This is probably good news: even if we cannot fully recover that frame, it is essentially never used.&lt;/p&gt;

&lt;p&gt;I have not yet found anything stupid on my side, sadly, nor seen warnings of SAM FIFO overflows. There are various counters on the SAM and the ASIC which can be reported more enthusiastically; I&apos;ll work on adding those under this ticket. &lt;/p&gt;</description>
                <environment></environment>
        <key id="23572">INSTRM-1993</key>
            <summary>Fix pixel drops at start of ramps</summary>
                <type id="1" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10503&amp;avatarType=issuetype">Bug</type>
                                            <priority id="3" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/major.svg">Major</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="cloomis">cloomis</assignee>
                                    <reporter username="cloomis">cloomis</reporter>
                        <labels>
                            <label>near-term</label>
                    </labels>
                <created>Thu, 15 Jun 2023 13:58:04 +0000</created>
                <updated>Fri, 28 Jul 2023 10:21:50 +0000</updated>
                            <resolved>Fri, 28 Jul 2023 10:21:50 +0000</resolved>
                                                                    <component>hxhal</component>
                    <component>ics_hxActor</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>1</watches>
                                                                <comments>
                            <comment id="33912" author="cloomis" created="Thu, 6 Jul 2023 17:15:07 +0000"  >&lt;p&gt;Partly inspired by &lt;a href=&quot;https://pfspipe.ipmu.jp/jira/browse/INSTRM-2013&quot; title=&quot;reported readTimes incorrect&quot; class=&quot;issue-link&quot; data-issue-key=&quot;INSTRM-2013&quot;&gt;&lt;del&gt;INSTRM-2013&lt;/del&gt;&lt;/a&gt;, I will completely validate the ASIC configuration which we read back at the start of each ramp. It can also be rewritten/reloaded, but that can take a while (10s of seconds in some cases) so we do not want to reconfigure unnecessarily. These values are not supposed to change, but I have seen the row window and number of outputs registers unexpectedly change. Both of which would completely mess things up.&lt;/p&gt;</comment>
                            <comment id="33987" author="cloomis" created="Mon, 10 Jul 2023 22:00:46 +0000"  >&lt;p&gt;About a third of the failures happened because the number of pixels expected for the ramp is calculated based on values read back from the ASIC, and sometimes those values are read back wrong. Simple fix for these particular ramps: calculate based on the values we wrote to the ASIC when configuring it.&lt;/p&gt;

&lt;p&gt;This seems moderately likely to be from errors on the SAM (ASIC register reads are done by programming some SAM registers; in one case the value of the register was the &lt;b&gt;address&lt;/b&gt; of the register): I think we will find similar problems with some of the other failed ramps.&lt;/p&gt;</comment>
                            <comment id="34018" author="cloomis" created="Fri, 14 Jul 2023 14:08:30 +0000"  >&lt;p&gt;I have made most of the changes required to notice failed ramps quickly, and restructured the inner &lt;tt&gt;takeRamp&lt;/tt&gt; method to support resuming a stopped ramp. But need a failure at this point before I can actually implement that. &lt;/p&gt;</comment>
                            <comment id="34151" author="cloomis" created="Tue, 25 Jul 2023 11:17:24 +0000"  >&lt;p&gt;I am going to close this one, although I do expect to have smaller followup tickets. Did four things, basically:&lt;/p&gt;

&lt;ul class=&quot;alternate&quot; type=&quot;square&quot;&gt;
	&lt;li&gt;ignore read back of the geometry registers, and instead use the values we wrote to them. This is the one problem which looks like hardware (&lt;b&gt;our&lt;/b&gt; hardware, at least).&lt;/li&gt;
	&lt;li&gt;be gentler about stopping a ramp in the middle, as we often do from sunss. Basically, set the ASIC to idle, but do &lt;b&gt;not&lt;/b&gt; reconfigure it. I still don&apos;t think I got this entirely right for all cases.&lt;/li&gt;
	&lt;li&gt;be more aggressive about initializing the SAM right before starting a ramp, and reporting errors.&lt;/li&gt;
	&lt;li&gt;start cleaning up after total failures in the inner loop. I will make a new ticket for finishing this work.&lt;/li&gt;
&lt;/ul&gt;
</comment>
                            <comment id="34173" author="cloomis" created="Wed, 26 Jul 2023 14:53:24 +0000"  >&lt;p&gt;Yeah, close it, but also look at 98434 on n1.&lt;/p&gt;</comment>
                            <comment id="34217" author="cloomis" created="Fri, 28 Jul 2023 10:21:50 +0000"  >&lt;p&gt;As commented, there will be more work, but this ticket should be closed.&lt;/p&gt;

&lt;p&gt;hxhal: tagged 3.1.1&lt;br/&gt;
ics_hxActor: tagged 2.7.9&lt;/p&gt;

&lt;p&gt;which is what we have been running for a couple of nights at the end of the 2023-07 run.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10003">
                    <name>Relates</name>
                                            <outwardlinks description="relates to">
                                        <issuelink>
            <issuekey id="23674">INSTRM-2013</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qpjd:00r20060i200186403c</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                        <customfield id="customfield_10005" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="166">Eng12July</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                    </customfields>
    </item>
</channel>
</rss>