https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1900 Instrument control development <p>When homing we take an mcs exposure, so we need where the cobras are.<br/> Use those positions to create a pfsConfig file and set pfiNominal /pfiCenter / targetType / fiberStatus correctly.<br/> for a non detected cobra, just set pfiCenter to nan and fiberStatus to BLACKSPOT.</p> INSTRM-1900

create pfsConfig after homing cobras

Task Normal Done Done arnaud.lefur arnaud.lefur EngRun Fri, 17 Mar 2023 16:03:58 +0000 Fri, 21 Apr 2023 01:22:24 +0000 Fri, 21 Apr 2023 01:22:24 +0000 ics_fpsActor 0 2 <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe" class="user-hover" rel="kiyoto.yabe">Kiyoto Yabe</a> on a side but slightly related topic, when you generate pfsDesign file, where is the code that's set targetType and fiberStatus ?<br/> I said that before, but since some of the "broken" cobras are collecting photon for the spectrograph, we have a spectra for it and we know where thy are on the sky, so I propose we set those to :<br/> targetType = UNASSIGNED and fiberStatus=GOOD<br/> And of course, for the one which are broken - broken, eg, no flux, we set :<br/> targetType = UNASSIGNED and fiberStatus=BROKEN</p> <p>Do you agree ? </p> <p>I think that part is somewhere in <a href="https://github.com/Subaru-PFS/ets_pointing/blob/main/pfs_design_tool/pointing_utils/designutils.py" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/ets_pointing/blob/main/pfs_design_tool/pointing_utils/designutils.py</a></p> <p>OK, so we don't introduce a specific fiberStatus like BROKENCOBRA and use UNASSIGNED target type as Paul suggested in <a href="https://pfspipe.ipmu.jp/jira/browse/DAMD-143" title="add brokenCobra to fiberStatus" class="issue-link" data-issue-key="DAMD-143"><del>DAMD-143</del></a>?</p> <p>Yes, I do agree with Paul proposal.<br/> And if we want to be consistent I think we should also add two new targetType :</p> <ul> <li>HOME</li> <li>BLACKSPOT</li> </ul> <p>merged as :</p> <ul> <li>iicActor:2.3.8</li> <li>fpsActor:1.6.2</li> <li>actorkeys:1.6.7</li> <li>datamodel:w.2023.16a</li> </ul> Development Rank 0|02qpjd:00r3000k0012o Sprint PreEng11Apr1 Story Points 2.0