https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1864 Instrument control development <p>ics_utils will grow a routine to generate a handful of FITS card for the pfsConfig PHDU. When creating pfsConfig files, retrieve that data and pass it to down to <tt>pfsConfig.write()</tt></p> INSTRM-1864

Pass observing info from gen2 to pfsConfig

Task Normal Done Done arnaud.lefur cloomis EngRun Tue, 14 Feb 2023 21:16:17 +0000 Mon, 20 Feb 2023 21:27:15 +0000 Mon, 20 Feb 2023 21:27:15 +0000 ics_iicActor 0 3 <p>so <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> report that cards will be created like this :</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>cards = getPfsConfigCards(actor, cmd, visit, date=None) </pre> </div></div> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a> Craig reports that would prefer this argument to be added directly in the constructor.<br/> But I'm actually using the copy method to create the "per-visit" pfsConfig file :</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>pfsConfig = pfsConfig0.copy(visit=visit) </pre> </div></div> <p>So we would need to add this argument to this method, is that fine with you ?</p> <p>That method takes <tt>**kwargs</tt>, so I think you only need to update the constructor.</p> <p>right but only for the keys in :</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>keywords = PfsConfig._keywords + PfsConfig._scalars + ['fiberStatus'] </pre> </div></div> <p>If we add the argument name to say PfsConfig_scalars that should indeed work.</p> <p>Yes, you absolutely need to add <tt>header</tt> to <tt>&#95;scalars</tt>. And please be sure to add something to the tests as well.</p> <p>I think these notes mostly belong in <a href="https://pfspipe.ipmu.jp/jira/browse/PIPE2D-1163" title="Allow adding FITS cards to pfsConfig PHDU" class="issue-link" data-issue-key="PIPE2D-1163"><del>PIPE2D-1163</del></a>....</p> <p>merged as iicActor:2.2.10</p> Blocks INSTRM-1863 Development Rank 0|02qpjd:00r3000k0010v Sprint PreEngRun10Feb