https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1845 Instrument control development <p>SM3 and hence SM2 locations were swapped, and now the cable B2 is connected to SM3. cobraId-fiberID relation is the same, but light path has changed. Columns <tt>id(BA)</tt> and <tt>id(BC)</tt> should be updated accordingly.</p> INSTRM-1845

Modify GFM reflecting the current cable connection

Task Normal Done Done yuki.moritani yuki.moritani Fri, 20 Jan 2023 10:25:33 +0000 Thu, 26 Jan 2023 19:11:21 +0000 Thu, 26 Jan 2023 19:11:21 +0000 pfs_utils 0 3 <p>Before uploading the modified file, I am wondering whether the filename, which includes the date of revision, should be kept. Changing the filename may cause the troubles for other people, so it might be better to keep the same filename..? (maybe we could delete the date from the filename?) Do you have any suggestions/opinions? &gt; <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=price" class="user-hover" rel="price">price</a> <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a> <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a></p> <p>I think you should rely on git for versioning, not filenames.</p> <p>I think we should be able to drop the date of the revision from the filename. The versions are controlled as git commits anyway. I am hoping most people access the GFM using the pfs_utils <tt>fiberids.py</tt> utility, so hopefully dropping the revision date does not impact on most people. </p> <p>Incidentally, <tt>fiberids.py</tt> seems to be able to read in any file of name <tt>grandfibermap*.txt</tt>, so that may not need to be updated following the renaming of the filename.</p> <p>Thank you for prompt comments. Yes, I can/should rely on git for versioning, rather than filename. So if you are fine to delete the date from the filename, may I do so under this ticket, assuming/hoping that nothing will break severely?</p> <p>I'm fine with making the change under this ticket.</p> <p>Changes in pull request <a href="https://github.com/Subaru-PFS/pfs_utils/pull/57" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/pfs_utils/pull/57</a> look fine to me.</p> <p>Thank you, Hassan, for review. I merged the banch.</p> Development Rank 0|zzsw0v: Reviewers hassan