https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1771 Instrument control development <p>From the docString, the pfs_utils function <tt>FiberIds.xyForCobras</tt> assumes some 0-indexed cobra identifier, but the code actually assumes <tt>fiberId</tt> (but 0-indexed, not 1-indexed as the actual <tt>fiberId</tt> identifier is):</p> <p><a href="https://github.com/Subaru-PFS/pfs_utils/blob/1edf4cb1ac8d5552daed299acc12200c75add4e8/python/pfs/utils/fiberids.py#L229-L242" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/pfs_utils/blob/1edf4cb1ac8d5552daed299acc12200c75add4e8/python/pfs/utils/fiberids.py#L229-L242</a></p> <p>Accessing the x, y coordinates for a given cobra by <tt>fiberId</tt> is IMO useful. So I propose to keep the function, but change the docString to assume a 1-indexed <tt>fiberId</tt>, and correct the implementation such that it works with a 1-indexed <tt>fiberId</tt>.</p> INSTRM-1771

Function FiberIds.xyForCobras() assumes 0-indexed fiberIds

Bug Normal Open Unresolved hassan hassan Thu, 27 Oct 2022 18:23:18 +0000 Thu, 27 Oct 2022 18:23:54 +0000 pfs_utils 0 1 Development Rank 0|zzsvbj: Story Points 1.0