https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1737 Instrument control development <p>We get the value of the FITS <tt>OBJECT</tt> card directly from the Gen2 <tt>PFS.OBJECT</tt> key, which is set by the PFS <tt>pfs_kansoku</tt> routines on Gen2 only when we (PFS) are running. To avoid stale values, we need to be a bit more careful.</p> <p>For SPS files (PFSA/PFSB), we can use the SM's <tt>lightSource</tt> value. If it is "pfi", use <tt>PFS.OBJECT</tt>, otherwise just use the lightSource ("dcb", "dcb2", "sunss", "none"). This does depend on the Gen2 kansoku scripts updating OBJECT correctly, but that is out of our hands.</p> <p>For AGCC, we should use <tt>PFS.OBJECT</tt> if <b>any</b> of the active lightSources are "pfi". Else we should use "unknown" for now, I think. We will eventually have a mechanism for telling that we are on the TUE system, but we don't know the details of that yet.</p> <p>For MCS, we should probably use the same scheme as AGCC. Maybe use the pfsDesign if we are on the PFI? That feels wrong to me, given that we do have the design itself.</p> INSTRM-1737

Set OBJECT card a bit more carefully.

Task Normal Open Unresolved cloomis cloomis EngRun Mon, 3 Oct 2022 23:28:23 +0000 Fri, 19 May 2023 16:36:43 +0000 ics_utils 0 3 <p>For PFI (PFSC/PFSD) file, I guess there is a case where test MCS camera (71M) is used.</p> <p>As talked in ICS/PFI+MCS telecon on 14 October 2022,  I'm trying to summarise the use cases:</p> <p><span class="image-wrap" style=""><a id="15419_thumb" href="https://pfspipe.ipmu.jp/jira/secure/attachment/15419/15419_Usecase_INSTRM1737.png" title="Usecase_INSTRM1737.png" file-preview-type="image" file-preview-id="15419" file-preview-title="Usecase_INSTRM1737.png"><img src="https://pfspipe.ipmu.jp/jira/secure/thumbnail/15419/_thumb_15419.png" style="border: 0px solid black" /></a></span></p> <p>Because the subsystems are used rather independently off the telescope, the table is a little complicated (I'm sorry). The right column shows proposed OBJECT card. Since there are many cases, I'd propose simply to use PFS.OBJECT key when command is sent from Gen2, and use "unknown" for any other cases, if it is feasible (red letter in the figure)...</p> <p>I'm just committing the PFSA changes now, though PFSB will get those. The logic is close to what was proposed:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>if data-typ in {bias, dark}: object = 'dark' elif lightSource in {dub, dcb2, sunss}: object = lightSource else: object = gen2.pfs.object </pre> </div></div> <p>If this is OK I'll merge the ics_utils and ccdActor parts and tag and install those.</p> <p>just adding another case for arc/flats taken on the telescope, set object to 'lamps' ?</p> Relates INSTRM-1767 Development Rank 0|02qpjd:00r20060i200186406 Story Points 2.0