https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1695 Instrument control development <p>When columns like L1,L2,tht<span class="error">&#91;12&#93;</span>,phi<span class="error">&#91;12&#93;</span> are updated in the model, the values should be sanity checked, to at least detect and trap nans and non-physical values before they get used or saved to new calibration files.</p> INSTRM-1695

Validate new pfiDesign values.

Task Normal Done Done chyan cloomis EngRun Mon, 12 Sep 2022 18:51:04 +0000 Fri, 14 Oct 2022 13:16:09 +0000 Fri, 7 Oct 2022 03:26:27 +0000 ics_cobraCharmer 0 4 <p>For example, from a recent report:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>On 14. Sep 2022, at 16:14, Javier Gracia Carpio &lt;jgracia@mpe.mpg.de&gt; wrote: I had a quick look at the calibration product that we are supposed to use and it contains 4 cobras with wrong L1 link lengths (should be less than 3mm). These are their ids: L1 = [141.01257827, 292.38620107, 345.00520847, 638.06690293] moduleIds=[13, 23, 27, 27] positionerIds=[54, 49, 12, 57] serialIds= [1138, 2002, 1075, 3058] </pre> </div></div> <p>Another thing to change is the phiIn and phiOut values for bad cobras. They seem to be set to 0 and -PI. However,  good cobras have phiIn and phiOut values that are arount -PI and 0. That means that the default values for bad cobras are inverted. They should have phiIn=-PI and phiOut=0</p> <p>Many bad cobras seem to have L1 and L2 link lengths set to 0.  The examples with very large L1 values that <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> mentions are also from bad cobras.</p> <p>I think we should provide default link lengths for those cobras.</p> <p>I have uploaded a new XML file. In this new XML file, the bad measurements pf L1 and L2 are replaced by reasonable values (median of all L1 and L2 lengths).</p> <p>As he has commented above, Chi-Hung has already uploaded the latest cobra XML file with corrected information. Ticket closed.</p> <p>Hi! Sorry for answering that late! I can confirm that the "problem" with the L1 and L2 lengths is solved. The problem with the phiIn, phiOut values for bad cobras is still present though.</p> <p>I nee to do the following to correct the values:</p> <p>badCobras = calibrationProduct.status != calibrationProduct.COBRA_OK_MASK<br/> calibrationProduct.phiIn<span class="error">&#91;badCobras&#93;</span> = -np.pi<br/> calibrationProduct.phiOut<span class="error">&#91;badCobras&#93;</span> = 0</p> <p> </p> <p>The XML has  phiIn=0 and phiOut=-pi for bad cobras</p> Relates INSTRM-1704 Development Rank 0|zzsuwf: Sprint preEngRun08Nov