[INSTRM-1618] update opdb schema to cope with the new pfsDesign finalize logic

Relates — Wed, 31 Aug 2022 19:07:46 +0000

So, some book-keeping details needs to be settled regarding our new pfsDesign finalize logic :

We'll have 4 new columns :

target_ra_final (proper motion tweaking)
target_dec_final (proper motion tweaking)
pfi_final_x_mm (proper motion + airmass)
pfi_final_y_mm (proper motion + airmass)

to track them, we (probably) need to change opdb schema.

so right now when IIC declareCurrentPfsDesign is called, IIC load the design and insert the "raw" design into those tables (pfs_design, pfs_design_fiber and pfs_design_agc, thanks Kiyoto Yabe).

we need a place to store those new information and one could argue that pfs_design_fiber has similar columns:

target_ra
target_dec
pfi_nominal_x_mm
pfi_nominal_y_mm

But we think with cloomis that we should keep the "raw designed" values and adding new columns there is not an option.

There is also the pfs_config_fiber table but it's only written after a convergence.
But we strongly think that you always want to write those designed values before you converge.

One solution would be to add a new table, something like :
pfs_design_fiber_final:

pfs_design_id
fiber_id
target_ra_final
target_dec_final
pfi_final_x_mm
pfi_final_y_mm

Which get written, when the tweaking is done, before starting the convergence.
Any idea, objections ? rhl

PFS-JIRA

[INSTRM-1618] update opdb schema to cope with the new pfsDesign finalize logic