[INSTRM-1529] comments on a PFSB sample file

Relates — Mon, 29 May 2023 03:38:18 +0000

Subaru FITS committee looked at a sample PFSB file (PFJB02548123.fits). There are comments as follows. Comments provided in ~~INSTRM-1444~~ are also applicable.

Misssing common keywords

BIN-FCT[1-2]
BLANK
BUNIT
DETECTOR
DET-TMP
EXP-ID
FRAMEID
GAIN

Missing Spectroscopy/Spectroscopy keywords

Note: listed for completeness - Subaru rule is being updated for MOS/fibre mode.

DISAXIS
DISPERSR
SLIT
SLITCPIX[1 -2]
SLIT-LEN
SLIT-PA
SLIT-WID
WAVELEN
WAVE-MAX
WAVE-MIN

Issues

Note: most of them have already discussed during the discussion on PFSA files.

WCS to be defined
default values for instrument & origin keywords such as TELESCOP, OBSERVAT, OBS-MOD to be checked
There are no time/temporal keywords in extension images. Is this acceptable?
EXPTIME exists only in primary HDU and no info for extension images. Is this acceptable? Comment is required. (EXPTIME=W_H4NRED*W_FRMTIM ?)
This file is not compressed. Is this a plan or will compression be enabled?
It is not clear what is in the 1st and 2nd extension, respectively (not exactly the FITS issue, though).
Do we plan to inclde additional HDUs per discussion on JIRA?
1. RESET HDU for IRP files? (~~INSTRM-1336~~) plus a keyword for indicating the file storing/reading (e.g., IRP or not) mode?
2. "at the end (summary) HDU" (~~DAMD-7~~) e.g., there is no direct info for NDR etc.
seems to be without IRP so we have no REF HDUs, correct?
Formatting for float values should be checked.

Undefined basic keyword

RA_CMD, DEC_CMD --> _These will be added to the Subaru's FITS dictionary if it's necessary to include them in the header of PFS data._

other minor comments