https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1413 Instrument control development INSTRM-1413

Update bore-sight calculation method in fpsActor

Task Normal Done Done karr chyan EngRun Fri, 22 Oct 2021 02:22:10 +0000 Tue, 16 Nov 2021 04:36:19 +0000 Tue, 16 Nov 2021 04:36:19 +0000 0 3 <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=chyan" class="user-hover" rel="chyan">chyan</a> can you provide a detailed description of the intended work please?</p> <p>A ticket branch is pushed to GitHub for addressing this ticket.  However, I noticed the implementation of <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1400" title="Implement boresight measurement routines" class="issue-link" data-issue-key="INSTRM-1400"><del>INSTRM-1400</del></a> is not merged yet.  Also, the implementation in that ticket is a function call, it should be a MCS command expose to users. <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=karr" class="user-hover" rel="karr">karr</a> would you please update and merge <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1400" title="Implement boresight measurement routines" class="issue-link" data-issue-key="INSTRM-1400"><del>INSTRM-1400</del></a>?  </p> <p>I checked and the boresight code is in master - the routines are in mcsRountes/mcsRoutines.py</p> <p>I've updated the calculateBoresight routine in the fpsActor to match the call in IIC (firstFrame + lastFrame), and to call the MCS routine. It should work regardless of the frameId/visitId system (multiple visits, or a single visit with multiple frame numbers). </p> <p> </p> <p>Changes look OK. Feel free to merge and close ticket <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=karr" class="user-hover" rel="karr">karr</a>.</p> Relates INSTRM-1400 Development Rank 0|zzsgpz: Sprint PreEngRun4 Story Points 2.0