https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1406 Instrument control development <p>Similarly to <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1405" title="Provide the measurement algorithm used for AG spots" class="issue-link" data-issue-key="INSTRM-1405"><del>INSTRM-1405</del></a>: it appears that the algorithm used to measure MCS spots is not written to the opDB.</p> <p>Please add a new column to the <tt>mcs_exposure</tt> table to specify the algorithm used.</p> INSTRM-1406

Provide the measurement algorithm used for MCS spots in the opDB

Task Normal Done Done Kiyoto Yabe hassan EngRun Fri, 15 Oct 2021 18:31:22 +0000 Wed, 17 Nov 2021 22:49:27 +0000 Wed, 17 Nov 2021 22:49:27 +0000 spt_operational_database 0 6 <p>I add a new column `measurement_algorithm` in `mcs_exposure` table. </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-python"> measurement_algorithm = Column(String, comment=<span class="code-quote">'Spot measurement algorithm (fast/slow)'</span>) </pre> </div></div> <p>I'm assuming that we only have `fast` and `slow` according to <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1412" title="Integrate multiple centroiding methods in agcc" class="issue-link" data-issue-key="INSTRM-1412"><del>INSTRM-1412</del></a>, but is this OK, <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=karr" class="user-hover" rel="karr">karr</a> <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hiro" class="user-hover" rel="hiro">Yoshida, Hiroshige</a> ?</p> <p>We'll need to be able to use these keywords to get back to an algorithm in GitHub. The SHA1 needn't be provided, of course, as we'll be tracking the MCS code versions. If there are additional important configuration parameters, we'll need to track them too.</p> <p>Isn't <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1412" title="Integrate multiple centroiding methods in agcc" class="issue-link" data-issue-key="INSTRM-1412"><del>INSTRM-1412</del></a> about the AGCC? This ticket is about the MCS. Were you thinking of <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1405" title="Provide the measurement algorithm used for AG spots" class="issue-link" data-issue-key="INSTRM-1405"><del>INSTRM-1405</del></a>?</p> <p>I thought it was the same in MCS, but maybe not. </p> <p>I think we should treat the two algorithms as different (even if they are currently coincidentally the same).</p> <p>The code for the two actors is currently separate, so it makes sense to have columns in both mcs_data and agcc_data, which currently have the same possible values but which could change in the future. </p> <p>One small question: do we need the column in `_data` table? I thought the algorithm is the same for all spots per exposure if we choose one algorithm, so I though it is sufficient to have the column in `_exposure` table.</p> <p>The same as <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1405" title="Provide the measurement algorithm used for AG spots" class="issue-link" data-issue-key="INSTRM-1405"><del>INSTRM-1405</del></a>. I have pushed the current changes. Could you review that if possible?</p> <p>The column for centroid method looks good to me. </p> <p>Changes also look fine to me.</p> <p>merged</p> Blocks INSTRM-1430 Relates INSTRM-1405 Development Rank 0|zzsgen: Reviewers hassan Sprint PreEngRun4 EngRun3Cleanup Story Points 2.0