PFS-JIRA https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 [INSTRM-1403] Add table to relate matched guidestar with spot https://pfspipe.ipmu.jp/jira/browse/INSTRM-1403 Instrument control development <p>Following from the ICS/PFI telecon 2021-10-15: provide a mapping between the observed objects using the AGC and the stars in the input catalogue. </p> <p>This might be just a join key from the <tt>guide_stars</tt> table to the <tt>agc_data</tt> table, but this should be investigated.</p> INSTRM-1403 Add table to relate matched guidestar with spot Task Normal Done Done Kiyoto Yabe hassan Fri, 15 Oct 2021 16:29:41 +0000 Fri, 5 Nov 2021 00:41:18 +0000 Fri, 5 Nov 2021 00:41:18 +0000 spt_operational_database 0 4 <p>I pushed the current implementation draft in <a href="https://github.com/Subaru-PFS/spt_operational_database/blob/tickets/INSTRM-1403/python/opdb/models.py" class="external-link" rel="nofollow">https://github.com/Subaru-PFS/spt_operational_database/blob/tickets/INSTRM-1403/python/opdb/models.py</a> </p> <p>We use the similar table as `cobra_match` for matching of spots on AGC like this. </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-python"> <span class="code-keyword">class </span>guide_star_match(Base): '''AGC matching information. ''' __tablename__ = <span class="code-quote">'guide_star_match'</span> __table_args__ = (UniqueConstraint(<span class="code-quote">'pfs_design_id'</span>, <span class="code-quote">'guide_star_id'</span>), ForeignKeyConstraint([<span class="code-quote">'agc_exposure_id'</span>, <span class="code-quote">'agc_camera_id'</span>, <span class="code-quote">'spot_id'</span>], [<span class="code-quote">'agc_data.agc_exposure_id'</span>, <span class="code-quote">'agc_data.agc_camera_id'</span>, <span class="code-quote">'agc_data.spot_id'</span>]), {}) pfs_design_id = Column(BigInteger, primary_key=<span class="code-keyword"><span class="code-object">True</span></span>, unique=<span class="code-keyword"><span class="code-object">False</span></span>, autoincrement=<span class="code-keyword"><span class="code-object">False</span></span>, comment=<span class="code-quote">'pfsDesignId'</span> ) guide_star_id = Column(BigInteger, primary_key=<span class="code-keyword"><span class="code-object">True</span></span>, unique=<span class="code-keyword"><span class="code-object">False</span></span>, autoincrement=<span class="code-keyword"><span class="code-object">False</span></span>, comment=<span class="code-quote">'GuideStar identifier'</span> ) agc_exposure_id = Column(Integer, comment=<span class="code-quote">'AGC exposure number identifier'</span>) agc_camera_id = Column(Integer, comment=<span class="code-quote">'AGC camera identifier'</span>) spot_id = Column(Integer, comment=<span class="code-quote">'The AGC spot identifier'</span>) column_placeholder = Column(REAL) flags = Column(Integer, comment=<span class="code-quote">'Flags'</span>) </pre> </div></div> <p>Any comments are welcome.</p> <p>I'm not sure who should be the reviewer but feel free to re-assign.</p> <p>The proposed table and key constraints look great. No additional comments.</p> <p>Sorry <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a>, after talking to <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hiro" class="user-hover" rel="hiro">Yoshida, Hiroshige</a> personally, we decided to revert to the original idea:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-python"> <span class="code-keyword">class </span>agc_match(Base): '''AGC matching information. ''' __tablename__ = <span class="code-quote">'agc_match'</span> __table_args__ = (UniqueConstraint(<span class="code-quote">'agc_exposure_id'</span>, <span class="code-quote">'agc_camera_id'</span>, <span class="code-quote">'spot_id'</span>), ForeignKeyConstraint([<span class="code-quote">'agc_exposure_id'</span>, <span class="code-quote">'agc_camera_id'</span>, <span class="code-quote">'spot_id'</span>], [<span class="code-quote">'agc_data.agc_exposure_id'</span>, <span class="code-quote">'agc_data.agc_camera_id'</span>, <span class="code-quote">'agc_data.spot_id'</span>]), {}) agc_exposure_id = Column(Integer, primary_key=<span class="code-keyword"><span class="code-object">True</span></span>, unique=<span class="code-keyword"><span class="code-object">False</span></span>, autoincrement=<span class="code-keyword"><span class="code-object">False</span></span>, comment=<span class="code-quote">'AGC exposure number identifier'</span>) agc_camera_id = Column(Integer, primary_key=<span class="code-keyword"><span class="code-object">True</span></span>, unique=<span class="code-keyword"><span class="code-object">False</span></span>, autoincrement=<span class="code-keyword"><span class="code-object">False</span></span>, comment=<span class="code-quote">'AGC camera identifier'</span>) spot_id = Column(Integer, primary_key=<span class="code-keyword"><span class="code-object">True</span></span>, unique=<span class="code-keyword"><span class="code-object">False</span></span>, autoincrement=<span class="code-keyword"><span class="code-object">False</span></span>, comment=<span class="code-quote">'The AGC spot identifier'</span>) pfs_design_id = Column(BigInteger, comment=<span class="code-quote">'pfsDesignId'</span>) guide_star_id = Column(BigInteger, comment=<span class="code-quote">'GuideStar identifier'</span>) agc_nominal_x_mm = Column(REAL, comment=<span class="code-quote">'Nominal designed x-position on the AGC [PFI mm]'</span>) agc_nominal_y_mm = Column(REAL, comment=<span class="code-quote">'Nominal designed y-position on the AGC [PFI mm]'</span>) agc_center_x_mm = Column(REAL, comment=<span class="code-quote">'Center measured x-position on the AGC [PFI mm]'</span>) agc_center_y_mm = Column(REAL, comment=<span class="code-quote">'Center measured y-position on the AGC [PFI mm]'</span>) flags = Column(Integer, comment=<span class="code-quote">'Flags'</span>) </pre> </div></div> <p> <br/> I also added columns for the designed and measured position of spots in PFI coordinate. The naming is similar to that in cobra tables (which is originated from datamodel in the long history), but it may not be so easy to understand. </p> <p>So, could both of you (<a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hassan" class="user-hover" rel="hassan">hassan</a>  and <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=hiro" class="user-hover" rel="hiro">Yoshida, Hiroshige</a>) review them again please?</p> <p>Thanks for the updates. But shouldn't the additional columns be in <tt>agc_data</tt>? </p> <p>As they are additional columns, and the main purpose of this ticket is to ensure we can map guidestar with spot, I'm fine if you and Yoshida-san feel that these additional columns are necessary.</p> <p>I think `agc_data` should contain purely detections and measured values in pix, so I excluded positions in mm from the table as in `mcs_data` and `cobra_match`. I'm not sure whether we need those information but it would be useful.</p> <p>Proposed schema seems acceptable for the Nov Eng Run. Further revisions after that may be possible but will be captured in future tickets.</p> <p>OK, I'll merge the current one.</p> Development Rank 0|zzsgdz: Reviewers hassan Sprint PreEngRun4 EngRun3Cleanup Story Points 2.0