https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1401 Instrument control development <p>Please:</p> <ul> <li>Populate the target table based on historical Sept eng run data.</li> <li>Load the target table based on the most recent targets prior to the next run.</li> </ul> INSTRM-1401

Populate target table

Task Normal Done Done chyan hassan EngRun Fri, 15 Oct 2021 12:13:09 +0000 Wed, 19 Jan 2022 03:36:36 +0000 Wed, 19 Jan 2022 03:36:36 +0000 0 3 <p>The ics_cobraCharmer produces the trajectory for all the moves. We should be able to insert those information into database. </p> <p>A branch of fpsActor is pushed to GitHub to address this ticket.</p> <p>Talked to Chih-Yi today and he pointed out there are two way to implement this. One solution is obviously in fpsActor and another one in down to the function of moveThetaPhi in CobraCoach.py since it calculate the angle for theta, phi for each iteration before the move. </p> <p>Turns out this is more complicated than what I thought.  The reason is addressed here.  cobra_target contains information from different levels <b>BOFORE</b> the cobra is actually moving.  It require visited, iteration (FPS), cobra location in mm (FPS), target location in mm (FPS), motor map information (cobraCoach), theta and phi angle (cobraCoach), theta and phi steps (cobraCharmer), theta and phi on-time (FPGA).   To insert only predicted angle is easy.  However, to input all those information at once is not straight-forward.  A possible implementation is passing an object all the way down to FPGA level and write information in every step.</p> <p>Two branches in ics_fpsActor and ics_cobraCharmer is pushed for populating target table.  This version only populated the information in cobraCharmer level.  We need to think about how to get information down to FPGA level (steps and on-time).</p> <p>I would need help from <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe" class="user-hover" rel="kiyoto.yabe">Kiyoto Yabe</a> regarding the database prime key issue. Currently, the cobra_target table is populated with (pfs_visit_id, iteration, cobra_id) because cobra_match table requires those information (prime key referencing). So, I may need a function that only updating the opdb table instead of writing. </p> <p>Maybe I don't understand what you want to do, but do you want to (for example) insert information other than (pfs_visit_id, iteration, cobra_id) into cobra_target after populating cobra_match table? Could you tell me example use cases?</p> <p>There is opdb.update method already implemented, but it's not fully tested. I'll check it to see whether it works properly.</p> <p>I tried db.update function, but it did not work.  There are two places I need to update the cobra_target table.  The first place is in <a href="https://github.com/Subaru-PFS/ics_mcsActor/blob/cb520471ece7c294f0633d922685ce58cf5dc6a6/python/mcsActor/Commands/McsCmd.py#L842" class="external-link" rel="nofollow">ics_mcsActor</a>. We need it before writing to cobra_match table. So, in MCS we only write three columns. However, we need update this table when we gather more information on where the cobra will go. I did some work arounds. The target table is populated and tested with bench system.</p> <p>Perhaps I missed the discussion point in the last meeting, but does simply swapping the relationship between `cobra_target` and `cobra_match` solve the issue? I mean (pfs_visit_id, iteration, cobra_id) of `cobra_target` refers `cobra_match`, so that you don't need to populate `cobra_target` first. This relationship looks a bit strange to me, but it is probably OK practically.</p> <p>Thanks for the comment, let me talk to Craig first. Then we decided how to do it. I think this is because cobra_match needs a reference from somewhere. Therefore, a pre-existed table is required.</p> <p>Thank you, I got the problem.</p> Blocks INSTRM-1497 Relates INSTRM-1388 Development Rank 0|02qpuc:i6001gr068fhw9qo4o0ry8y Sprint PreEngRun4 EngRun3Cleanup PreEngRun05 A PreEngRun05 B Story Points 1.0