https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1393 Instrument control development <p>The <tt>PfiTransform.updateTransform()</tt> method should after establishing the revised transform coefficients, write those coefficients to the opDB.</p> INSTRM-1393

PfiTransform should write updated transformation coefficients to opDB

Task Normal Won't Fix Won't Fix chyan hassan EngRun Mon, 11 Oct 2021 17:01:11 +0000 Fri, 2 Sep 2022 12:56:32 +0000 Fri, 15 Jul 2022 03:49:24 +0000 pfs_utils 0 5 <p>We may want to postpone this until after <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1402" title="update the transforms and make the pfi &lt;--&gt; mcs transforms exactly round trip" class="issue-link" data-issue-key="INSTRM-1402"><del>INSTRM-1402</del></a> is complete and we have a better idea of the needed coefficients. However, it's probably safe to assume that we'll need at least <tt>dx, dy, dtheta, a, b</tt> where the radial scale is <tt>1 + a + b r^2</tt></p> <p>There is a table called camera_model_f3c_mcs.  I think that is the good place for storing all those coefficients.</p> <p><a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=rhl" class="user-hover" rel="rhl">rhl</a> <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a> <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe" class="user-hover" rel="kiyoto.yabe">Kiyoto Yabe</a> <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=yuki.moritani" class="user-hover" rel="yuki.moritani">yuki.moritani</a> Question: are the distortion parameters static? If so should they be written to the opDB or to <tt>pfs_instdata</tt>? <br/> If the former, the next step is to check with <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=kiyoto.yabe" class="user-hover" rel="kiyoto.yabe">Kiyoto Yabe</a> whether the <tt>camera_model_f3c_mcs</tt> is the correct table, whether it requires a schema update, or whether a different table should be used.</p> <p>If these coefficients are static, a location under <tt>pfs_instdata</tt> needs to be agreed.</p> <p>Finally, the distortion parameters may be a function of elevation and instrument rotator angle, so a more general means of modeling the distortion parameters may need to be considered.</p> <p>I personally think coefficients that Robert raised are expected to be dynamic..?</p> <p>Following discussions during the ICS/PFI telecon 2021-12-23: </p> <p>1. the transformations are dynamic. <br/> 2. More information is needed before this work can commence. And <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=yuki.moritani" class="user-hover" rel="yuki.moritani">yuki.moritani</a> needs to think more about the coordinate transformations.</p> <p>This ticket will be rescheduled to a later sprint.</p> <p>Closing this ticket. Work is being addressed in <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1394" title="Update PFI-MCS transformation tables on opDB" class="issue-link" data-issue-key="INSTRM-1394"><del>INSTRM-1394</del></a>.</p> Relates INSTRM-1394 Development Rank 0|02qpib: Sprint PreEngRun4 EngRun3Cleanup preEngRun07Sep Story Points 2.0