https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1298 Instrument control development <p>There is a new <tt>insert_copy_from</tt> method on Opdb which allows efficient copying from the user to the database, which is absolutely necessary for FPS/MCS operations. Those actors also need to copy from the database to the user &#8211; the MCS needs the FPS targets, and the FPS needs the MCS matches.</p> <p>So can we add <tt>select_by_copy(sqlSelect</tt> or something? I admit that I get confused by the postgres terminology of COPY_FROM and COPY_TO. We probably do not need to expose the internal postgres names that way, so <tt>insert_by_copy. select_by_copy</tt>, or <tt>insertBulk, selectBulk</tt> might be better?</p> <p>Also, can the opdb methods have the context manager or try-except wrapping? Leaving transactions open on failures causes all sorts of trouble later.</p> INSTRM-1298

Add select_copy_to method

Task Normal Done Done Kiyoto Yabe cloomis Mon, 21 Jun 2021 17:10:57 +0000 Wed, 14 Jul 2021 22:56:30 +0000 Wed, 14 Jul 2021 22:56:30 +0000 spt_operational_database 0 3 <blockquote><p>can the opdb methods have the context manager or try-except wrapping</p></blockquote> <p>surely we should use the context managers not <tt>try/except</tt> in all new code.</p> <p>I <b>strongly</b> agree, but the sqlalchemy proxy for the psycopg2 engine does not obviously have a working context manager. New versions might.</p> <p>For select_by_copy method, I think I can implement that. Considering existing method names, is it OK to name them `insert_by_copy` and `fetch_by_copy`? </p> <p>For the error handling, I think I can consider the context manager, though it may be beyond my ability to design and implement. Could you make a separate ticket for this, just in case? <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=cloomis" class="user-hover" rel="cloomis">cloomis</a></p> <p>I'm moving the request to use context managers to a separate ticket so that the copy_{to, from} work can be merged.</p> Development Rank 0|zzs8co: