<!-- 
RSS generated by JIRA (8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b) at Sat Feb 10 16:33:54 JST 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>PFS-JIRA</title>
    <link>https://pfspipe.ipmu.jp/jira</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>8.3.4</version>
        <build-number>803005</build-number>
        <build-date>13-09-2019</build-date>
    </build-info>


<item>
            <title>[INSTRM-1296] Add IIC commands for main FPS routines.</title>
                <link>https://pfspipe.ipmu.jp/jira/browse/INSTRM-1296</link>
                <project id="10300" key="INSTRM">Instrument control development</project>
                    <description>&lt;p&gt;The following are the main FPS commands which require a visit id, and so &lt;b&gt;must&lt;/b&gt; be commanded from iic. Note that there are a couple of cosmetic changes from the existing code; please use this list.&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;  (&apos;moveToPfsDesign&apos;, &apos;&amp;lt;visit&amp;gt; &amp;lt;pfsDesign&amp;gt;&apos;, ),
  (&apos;movePhiToAngle&apos;, &apos;&amp;lt;visit&amp;gt; &amp;lt;angle&amp;gt; &amp;lt;iteration&amp;gt;&apos;, ),
  (&apos;moveToHome&apos;, &apos;&amp;lt;visit&amp;gt; @(phi|theta|all)&apos;, ),
  (&apos;moveToSafePosition&apos;, &apos;&amp;lt;visit&amp;gt;&apos;, ),
  (&apos;gotoVerticalFromPhi60&apos;, &apos;&amp;lt;visit&amp;gt;&apos;, ),
  (&apos;makeMotorMap&apos;, &apos;&amp;lt;visit&amp;gt; @(phi|theta) &amp;lt;stepsize&amp;gt; &amp;lt;repeat&amp;gt; [@slowOnly]&apos;, ),
  (&apos;makeOntimeMap&apos;, &apos;&amp;lt;visit&amp;gt; @(phi|theta)&apos;, ),
  (&apos;angleConvergenceTest&apos;, &apos;&amp;lt;visit&amp;gt; @(phi|theta) &amp;lt;angleTargets&amp;gt;&apos;, ),
  (&apos;targetConvergenceTest&apos;, &apos;&amp;lt;visit&amp;gt; @(ontime|speed) &amp;lt;totalTargets&amp;gt; &amp;lt;maxsteps&amp;gt;&apos;, ),
  (&apos;motorOntimeSearch&apos;, &apos;&amp;lt;visit&amp;gt; @(phi|theta)&apos;, ),
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;I imagine we will rename &lt;tt&gt;gotoVerticalFromPhi60&lt;/tt&gt;, but perhaps not right now.&lt;/p&gt;</description>
                <environment></environment>
        <key id="16894">INSTRM-1296</key>
            <summary>Add IIC commands for main FPS routines.</summary>
                <type id="3" iconUrl="https://pfspipe.ipmu.jp/jira/secure/viewavatar?size=xsmall&amp;avatarId=10518&amp;avatarType=issuetype">Task</type>
                                            <priority id="10000" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/priorities/medium.svg">Normal</priority>
                        <status id="10002" iconUrl="https://pfspipe.ipmu.jp/jira/images/icons/statuses/generic.png" description="The issue is resolved, reviewed, and merged">Done</status>
                    <statusCategory id="3" key="done" colorName="green"/>
                                    <resolution id="10000">Done</resolution>
                                        <assignee username="arnaud.lefur">arnaud.lefur</assignee>
                                    <reporter username="cloomis">cloomis</reporter>
                        <labels>
                            <label>EngRun</label>
                    </labels>
                <created>Mon, 21 Jun 2021 14:37:39 +0000</created>
                <updated>Thu, 14 Oct 2021 17:40:17 +0000</updated>
                            <resolved>Thu, 9 Sep 2021 01:46:21 +0000</resolved>
                                                                    <component>ics_iicActor</component>
                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                <comments>
                            <comment id="21541" author="arnaud.lefur" created="Mon, 21 Jun 2021 15:24:54 +0000"  >&lt;p&gt;fair enough, so these are the equivalent of an _sps expose visit=.. _basically ?&lt;br/&gt;
So we would need one iic command/sequence per fps command ?&lt;br/&gt;
Do we need external argument at the iic level, duplicate=.. for instance to run the same fps command several times ?&lt;/p&gt;</comment>
                            <comment id="21542" author="cloomis" created="Mon, 21 Jun 2021 16:57:35 +0000"  >&lt;p&gt;Yes, one iic sequence per command. Umm, resources would be the MCS, the SPS back-illuminators, FPS itself, and possibly some internal PEB illuminator (for the fiducials). &lt;/p&gt;

&lt;p&gt;No duplicates. Internally there is that &lt;tt&gt;repeat&lt;/tt&gt; for &lt;tt&gt;makeMotorMap&lt;/tt&gt; but I suspect it can&apos;t be used because of the 100-frame limit, and the making a motor map is such a huge process that supporting duplicates at the iic level is a bit crazy.&lt;/p&gt;

&lt;p&gt;Hmm. The existing &lt;tt&gt;FpsCmd.py&lt;/tt&gt; predates integration of PfsDesign. I just added a &lt;tt&gt;&amp;lt;pfsDesign&amp;gt;&lt;/tt&gt; argument to &lt;tt&gt;moveToPfsDesign&lt;/tt&gt;, but it is not quite obvious how `iic` should get the design. It will be provided by some external program.&lt;/p&gt;

&lt;p&gt;The existing boresight commands are real and must be kept functional. The set of them run in a slightly odd dance.&lt;/p&gt;</comment>
                            <comment id="21554" author="arnaud.lefur" created="Tue, 22 Jun 2021 17:46:26 +0000"  >&lt;p&gt;I made some good progress today, now I need to fix some opdb issues.&lt;/p&gt;
&lt;div class=&quot;preformatted panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;preformattedContent panelContent&quot;&gt;
&lt;pre&gt;2021-06-22T17:25:19.299 iic f text=&quot;command failed: IntegrityError(&apos;(psycopg2.errors.ForeignKeyViolation) insert or update on table \&quot;visit_set\&quot; violates foreign key constraint \&quot;visit_set_pfs_visit_id_fkey\&quot;\nDETAIL:  Key (pfs_visit_id)=(311) is not present in table \&quot;sps_visit\&quot;.\n&apos;) in do_execute() at /home/arnaud/miniconda3/lib/python3.7/site-packages/sqlalchemy/engine/default.py:588&quot;
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;
&lt;p&gt;which means that visit_set and sps_visit are linked somehow.&lt;br/&gt;
but if sps_sequence=&amp;gt; iic_sequence, mcs_visit would also to be tracked in visit_set.&lt;/p&gt;
</comment>
                            <comment id="21933" author="arnaud.lefur" created="Thu, 9 Sep 2021 01:46:21 +0000"  >&lt;p&gt;still a bit crude but mergeable&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10000">
                    <name>Blocks</name>
                                                                <inwardlinks description="is blocked by">
                                        <issuelink>
            <issuekey id="16895">INSTRM-1297</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="16907">INSTRM-1305</issuekey>
        </issuelink>
                            </inwardlinks>
                                    </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                <customfield id="customfield_10500" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                            <customfield id="customfield_10010" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>0|02qpuc:i6001gr068fhw9qo4o0s</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10100" key="com.atlassian.jira.plugin.system.customfieldtypes:userpicker">
                        <customfieldname>Reviewers</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>cloomis</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10005" key="com.pyxis.greenhopper.jira:gh-sprint">
                        <customfieldname>Sprint</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue id="118">EngRun03</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10002" key="com.atlassian.jira.plugin.system.customfieldtypes:float">
                        <customfieldname>Story Points</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>4.0</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                                                        </customfields>
    </item>
</channel>
</rss>