https://pfspipe.ipmu.jp/jira This file is an XML representation of an issue en-us 8.3.4 803005 13-09-2019 https://pfspipe.ipmu.jp/jira/browse/INSTRM-1293 Instrument control development <p>If we want to insert sps_sequence at the beginning, we need to pull out status column which is obviously known only at the end.</p> <p>We would need a new table : <br/> sps_sequence_status: </p> <ul> <li>visit_set_id int4 not null</li> <li>status_flag int4</li> <li>comments varchar</li> </ul> <p>You need to create the table in the first place then I will dump data from the existing column to the new table, then we can drop the status column from sps_sequence.</p> INSTRM-1293

pull out status column from sps_sequence table

Task Normal Done Done Kiyoto Yabe arnaud.lefur SPS Thu, 17 Jun 2021 16:02:21 +0000 Wed, 14 Jul 2021 22:56:04 +0000 Wed, 14 Jul 2021 22:56:04 +0000 spt_operational_database 0 3 <p>OK, making a new table is very easy, but migrating existing data is a little bit tricky, so we need a coordination. We are going to update the opDB schema very soon for the PFI integration anyway, so we can target then for this update. Is this needed for only `obslog` business?</p> <p>Right. Yes, that's the main reason.</p> <p>With <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1291" title="Create visit_set and sps_sequence rows as soon as practical." class="issue-link" data-issue-key="INSTRM-1291"><del>INSTRM-1291</del></a> merged, we're ready to go forward. <br/> But regarding the migration, we could maybe take advantage of <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1305" title="rename sps_sequence to iic_sequence in opdb" class="issue-link" data-issue-key="INSTRM-1305"><del>INSTRM-1305</del></a>, we copy <em>sps_sequence</em> to <em>iic_sequence</em> (without status column) and we keep <em>sps_sequence</em> as backup while we do the migration, <em>sps_sequence_status</em> should also be renamed to <em>iic_sequence_status</em> I believe.</p> <p>In terms of <em>alembic</em> operation, the following procedure is easier for me:</p> <ul> <li>create `iic_sequence` and `iic_sequence_status` (keeping `sps_sequence`) with alembic update (as a part of <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1293" title="pull out status column from sps_sequence table" class="issue-link" data-issue-key="INSTRM-1293"><del>INSTRM-1293</del></a>)</li> <li>migrate existing records from `sps_sequence` to `iic_sequence` and `iic_sequence_status` (currently ~13000 rows, so not so large)</li> <li>update `visit_set` constraints and drop `sps_sequence` (as a part of <a href="https://pfspipe.ipmu.jp/jira/browse/INSTRM-1305" title="rename sps_sequence to iic_sequence in opdb" class="issue-link" data-issue-key="INSTRM-1305"><del>INSTRM-1305</del></a>)</li> <li>we probably need to ask <a href="https://pfspipe.ipmu.jp/jira/secure/ViewProfile.jspa?name=michitaro" class="user-hover" rel="michitaro">michitaro</a> to change `obslog` before we remove `sps_sequence`</li> </ul> <p>BTW, `output` (in `iic_sequence_status`) seems a <em>reserved</em> keyword by SQL (not by postgres, but one cannot rule out the possibility that it becomes reserved by postgres in future). Any other good candidate names? If not, we can proceed with it, I think.</p> <p>sounds good.</p> <p>okay, let's switch to <em>cmd_output</em> then.</p> Blocks INSTRM-1291 Development Rank 0|zzs4yd:i Sprint SM1PD-2021 A 12